From: Alexander Aring <alex.aring@gmail.com>
To: Simon Vincent <simon.vincent@xsilon.com>
Cc: linux-wpan@vger.kernel.org
Subject: Re: problems with udp header compression
Date: Sat, 1 Nov 2014 10:10:55 +0100 [thread overview]
Message-ID: <20141101091052.GB31204@omega> (raw)
In-Reply-To: <5452107B.8010805@xsilon.com>
Hi Simon,
On Thu, Oct 30, 2014 at 10:18:35AM +0000, Simon Vincent wrote:
> This appears to be because if you use a RAW socket with IPPROTO_RAW the ipv6
> stack passes it straight through and the skb transport_header,
> network_header offset are not set.
>
> Putting the following at the top of compress_udp_header fixes the problem
> but I am not sure it is safe.
> if (skb->transport_header == skb->network_header){
> skb_set_transport_header(skb,sizeof(struct ipv6hdr));
> }
>
I see, this could make trouble for IPV6 RAW sockets. Can you please send
a patch for this and cc linux-bluetooth and linux-wpan. Also add some
comment why we do this is here, because the RAW socket issue.
Or just send it as RFC (means replace the PATCH into RFC in the
subject). Then we can talk about a better solution if this isn't a
perfect solution.
Also remove the unnecessary brackets -> checkpatch should show an error
because this.
- Alex
next prev parent reply other threads:[~2014-11-01 9:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-30 9:42 problems with udp header compression Simon Vincent
2014-10-30 10:18 ` Simon Vincent
2014-11-01 9:10 ` Alexander Aring [this message]
2014-11-04 12:34 ` Simon Vincent
2014-11-04 12:37 ` Alexander Aring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141101091052.GB31204@omega \
--to=alex.aring@gmail.com \
--cc=linux-wpan@vger.kernel.org \
--cc=simon.vincent@xsilon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox