From: Alexander Aring <alex.aring@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: linux-wpan@vger.kernel.org
Subject: Re: [patch] ieee802154: || vs && in ieee802154_is_valid_extended_addr()
Date: Tue, 4 Nov 2014 10:12:55 +0100 [thread overview]
Message-ID: <20141104091252.GA643@omega> (raw)
In-Reply-To: <20141104085509.GA12954@mwanda>
On Tue, Nov 04, 2014 at 11:55:09AM +0300, Dan Carpenter wrote:
> The ieee802154_is_valid_extended_addr() always returns true because
> there is a typo. The || should be &&. Neither 0x0000000000000000ULL
> nor 0xffffffffffffffffULL are valid addresses.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Acked-by: Alexander Aring <alex.aring@gmail.com>
next prev parent reply other threads:[~2014-11-04 9:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-03 20:41 ieee802154: add extended address validation helper Dan Carpenter
2014-11-04 0:01 ` Alexander Aring
2014-11-04 8:55 ` [patch] ieee802154: || vs && in ieee802154_is_valid_extended_addr() Dan Carpenter
2014-11-04 9:12 ` Alexander Aring [this message]
2014-11-04 16:45 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141104091252.GA643@omega \
--to=alex.aring@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=linux-wpan@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox