linux-wpan.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH wpan-tools 0/3] Distcheck and dependency fixes
@ 2014-12-05 17:55 Stefan Schmidt
  2014-12-05 17:55 ` [PATCH wpan-tools 1/3] configure: Fail if libnl3 dependency is not found Stefan Schmidt
                   ` (3 more replies)
  0 siblings, 4 replies; 5+ messages in thread
From: Stefan Schmidt @ 2014-12-05 17:55 UTC (permalink / raw)
  To: linux-wpan; +Cc: Alexander Aring, Stefan Schmidt

Hello.

Some small patches I did when I first tried wpan-tools. I hit the first one when trying to compile
them without libnl3-devel installed and configure happily worked. The last two are two make sure we
can use make distcheck to generate some release tarballs at some point.

Stefan Schmidt (3):
  configure: Fail if libnl3 dependency is not found
  build: add header files to SOURCES
  configure: do not use check-news for now

 configure.ac    | 3 +--
 src/Makefile.am | 5 ++++-
 2 files changed, 5 insertions(+), 3 deletions(-)

-- 
1.9.3


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH wpan-tools 1/3] configure: Fail if libnl3 dependency is not found
  2014-12-05 17:55 [PATCH wpan-tools 0/3] Distcheck and dependency fixes Stefan Schmidt
@ 2014-12-05 17:55 ` Stefan Schmidt
  2014-12-05 17:55 ` [PATCH wpan-tools 2/3] build: add header files to SOURCES Stefan Schmidt
                   ` (2 subsequent siblings)
  3 siblings, 0 replies; 5+ messages in thread
From: Stefan Schmidt @ 2014-12-05 17:55 UTC (permalink / raw)
  To: linux-wpan; +Cc: Alexander Aring, Stefan Schmidt

The conditionals are not used anywhere and we have a hard dependency on
libnl3 so fail if we do not detect it during configure.

Signed-off-by: Stefan Schmidt <s.schmidt@samsung.com>
---
 configure.ac | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configure.ac b/configure.ac
index 791607f..6ad60f5 100644
--- a/configure.ac
+++ b/configure.ac
@@ -31,7 +31,7 @@ AC_PREFIX_DEFAULT([/usr])
 AC_PROG_SED
 AC_PROG_MKDIR_P
 
-PKG_CHECK_MODULES(LIBNL3, [libnl-3.0 >= 3.1 libnl-genl-3.0 >= 3.1], [have_libnl3=yes], [have_libnl3=no])
+PKG_CHECK_MODULES(LIBNL3, [libnl-3.0 >= 3.1 libnl-genl-3.0 >= 3.1])
 
 AC_CHECK_FUNCS([ \
 	__secure_getenv \
-- 
1.9.3


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH wpan-tools 2/3] build: add header files to SOURCES
  2014-12-05 17:55 [PATCH wpan-tools 0/3] Distcheck and dependency fixes Stefan Schmidt
  2014-12-05 17:55 ` [PATCH wpan-tools 1/3] configure: Fail if libnl3 dependency is not found Stefan Schmidt
@ 2014-12-05 17:55 ` Stefan Schmidt
  2014-12-05 17:55 ` [PATCH wpan-tools 3/3] configure: do not use check-news for now Stefan Schmidt
  2014-12-07  9:46 ` [PATCH wpan-tools 0/3] Distcheck and dependency fixes Alexander Aring
  3 siblings, 0 replies; 5+ messages in thread
From: Stefan Schmidt @ 2014-12-05 17:55 UTC (permalink / raw)
  To: linux-wpan; +Cc: Alexander Aring, Stefan Schmidt

We need to specify them here or they will not end up in the tarball and thus
distcheck would fail.

Signed-off-by: Stefan Schmidt <s.schmidt@samsung.com>
---
 src/Makefile.am | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/src/Makefile.am b/src/Makefile.am
index 26f73b8..2d54576 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -3,11 +3,14 @@ bin_PROGRAMS = \
 
 iwpan_SOURCES = \
 	iwpan.c \
+	iwpan.h \
 	sections.c \
 	info.c \
 	interface.c \
 	phy.c \
-	mac.c
+	mac.c \
+	nl_extras.h \
+	nl802154.h
 
 iwpan_CFLAGS = $(AM_CFLAGS) $(LIBNL3_CFLAGS)
 iwpan_LDADD = $(LIBNL3_LIBS)
-- 
1.9.3


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [PATCH wpan-tools 3/3] configure: do not use check-news for now
  2014-12-05 17:55 [PATCH wpan-tools 0/3] Distcheck and dependency fixes Stefan Schmidt
  2014-12-05 17:55 ` [PATCH wpan-tools 1/3] configure: Fail if libnl3 dependency is not found Stefan Schmidt
  2014-12-05 17:55 ` [PATCH wpan-tools 2/3] build: add header files to SOURCES Stefan Schmidt
@ 2014-12-05 17:55 ` Stefan Schmidt
  2014-12-07  9:46 ` [PATCH wpan-tools 0/3] Distcheck and dependency fixes Alexander Aring
  3 siblings, 0 replies; 5+ messages in thread
From: Stefan Schmidt @ 2014-12-05 17:55 UTC (permalink / raw)
  To: linux-wpan; +Cc: Alexander Aring, Stefan Schmidt

We do not use a NEWS file right now and without it distcheck will fail
with this option. We can bring it back when we are going to use a NEWS
file for keeping track.

Signed-off-by: Stefan Schmidt <s.schmidt@samsung.com>
---
 configure.ac | 1 -
 1 file changed, 1 deletion(-)

diff --git a/configure.ac b/configure.ac
index 6ad60f5..9aa6330 100644
--- a/configure.ac
+++ b/configure.ac
@@ -5,7 +5,6 @@ AC_INIT([Userspace tools for Linux IEEE 802.15.4 stack],
 AC_CONFIG_SRCDIR([src/iwpan.c])
 AC_CONFIG_AUX_DIR([build-aux])
 AM_INIT_AUTOMAKE([
-	check-news
 	foreign
 	1.11
 	-Wall
-- 
1.9.3


^ permalink raw reply related	[flat|nested] 5+ messages in thread

* Re: [PATCH wpan-tools 0/3] Distcheck and dependency fixes
  2014-12-05 17:55 [PATCH wpan-tools 0/3] Distcheck and dependency fixes Stefan Schmidt
                   ` (2 preceding siblings ...)
  2014-12-05 17:55 ` [PATCH wpan-tools 3/3] configure: do not use check-news for now Stefan Schmidt
@ 2014-12-07  9:46 ` Alexander Aring
  3 siblings, 0 replies; 5+ messages in thread
From: Alexander Aring @ 2014-12-07  9:46 UTC (permalink / raw)
  To: Stefan Schmidt; +Cc: linux-wpan

Hi Stefan,

On Fri, Dec 05, 2014 at 06:55:41PM +0100, Stefan Schmidt wrote:
> Hello.
> 
> Some small patches I did when I first tried wpan-tools. I hit the first one when trying to compile
> them without libnl3-devel installed and configure happily worked. The last two are two make sure we
> can use make distcheck to generate some release tarballs at some point.
> 

great. Patches applied.

Thanks.

- Alex

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2014-12-07  9:47 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-05 17:55 [PATCH wpan-tools 0/3] Distcheck and dependency fixes Stefan Schmidt
2014-12-05 17:55 ` [PATCH wpan-tools 1/3] configure: Fail if libnl3 dependency is not found Stefan Schmidt
2014-12-05 17:55 ` [PATCH wpan-tools 2/3] build: add header files to SOURCES Stefan Schmidt
2014-12-05 17:55 ` [PATCH wpan-tools 3/3] configure: do not use check-news for now Stefan Schmidt
2014-12-07  9:46 ` [PATCH wpan-tools 0/3] Distcheck and dependency fixes Alexander Aring

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).