Re: [PATCH] at86rf230: fix register read for part version

[Alexander Aring <alex.aring@gmail.com>]

Hi Andrey,

On Wed, Dec 17, 2014 at 01:14:42PM -0800, Andrey Yurovsky wrote:
> The driver was reading the PART_NUM register for both the part number
> (type of device) and the part version, the version is actually in
> register 0x1D, VERSION_NUM.  I believe that this was a copy-paste error.
> 
> Tested on AT86RF212B where the part is detected to be the expected part
> number (0x07) and version (0x03 on mine).
> 
> Signed-off-by: Andrey Yurovsky <andrey@snupi.com>
> ---
>  drivers/net/ieee802154/at86rf230.c | 18 +++++++-----------
>  1 file changed, 7 insertions(+), 11 deletions(-)
> 
> diff --git a/drivers/net/ieee802154/at86rf230.c b/drivers/net/ieee802154/at86rf230.c
> index 1c01356..aa1005f 100644
> --- a/drivers/net/ieee802154/at86rf230.c
> +++ b/drivers/net/ieee802154/at86rf230.c
> @@ -1400,7 +1400,7 @@ at86rf230_detect_device(struct at86rf230_local *lp)
>  	if (rc)
>  		return rc;
>  
> -	rc = __at86rf230_read(lp, RG_PART_NUM, &version);
> +	rc = __at86rf230_read(lp, RG_VERSION_NUM, &version);

oops, yes this is indeed wrong here. Thanks!

Acked-by: Alexander Aring <alex.aring@gmail.com>

- Alex