From: Alexander Aring <alex.aring@gmail.com>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: linux-wpan@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH bluetooth-next RESEND] at86rf230: cleanup check on trac status
Date: Fri, 19 Dec 2014 12:02:35 +0100 [thread overview]
Message-ID: <20141219110231.GA15986@omega> (raw)
In-Reply-To: <6AC2F7D7-DA76-4D7C-B49C-485E3F25414F@holtmann.org>
On Fri, Dec 19, 2014 at 11:57:24AM +0100, Marcel Holtmann wrote:
> Hi Alex,
>
> > Signed-off-by: Alexander Aring <alex.aring@gmail.com>
> > Reviewed-by: Stefan Schmidt <s.schmidt@samsung.com>
> > ---
> > drivers/net/ieee802154/at86rf230.c | 8 +++-----
> > 1 file changed, 3 insertions(+), 5 deletions(-)
>
> patch has been applied to bluetooth-next tree.
>
> I would however prefer that even these small patches get a commit message explaining why that is correct and now was wrong before. Does not have to be anything big, but at least some sort of commit message body clearly explaining it would be helpful.
>
Okay, thanks.
I need to admit that writing commit messages in some cases is more work than
to write the programming changes.
Nevertheless I will try to change that.
- Alex
prev parent reply other threads:[~2014-12-19 11:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-19 9:36 [PATCH bluetooth-next RESEND] at86rf230: cleanup check on trac status Alexander Aring
2014-12-19 10:57 ` Marcel Holtmann
2014-12-19 11:02 ` Alexander Aring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20141219110231.GA15986@omega \
--to=alex.aring@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-wpan@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).