* [PATCH bluetooth-next RESEND] at86rf230: cleanup check on trac status
@ 2014-12-19 9:36 Alexander Aring
2014-12-19 10:57 ` Marcel Holtmann
0 siblings, 1 reply; 3+ messages in thread
From: Alexander Aring @ 2014-12-19 9:36 UTC (permalink / raw)
To: linux-wpan; +Cc: kernel, Alexander Aring
Signed-off-by: Alexander Aring <alex.aring@gmail.com>
Reviewed-by: Stefan Schmidt <s.schmidt@samsung.com>
---
drivers/net/ieee802154/at86rf230.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/net/ieee802154/at86rf230.c b/drivers/net/ieee802154/at86rf230.c
index 79fbf38..80632fc 100644
--- a/drivers/net/ieee802154/at86rf230.c
+++ b/drivers/net/ieee802154/at86rf230.c
@@ -749,13 +749,11 @@ at86rf230_tx_trac_check(void *context)
* to STATE_FORCE_TRX_OFF then STATE_TX_ON to recover the transceiver
* state to TX_ON.
*/
- if (trac) {
+ if (trac)
at86rf230_async_state_change(lp, ctx, STATE_FORCE_TRX_OFF,
at86rf230_tx_trac_error, true);
- return;
- }
-
- at86rf230_tx_on(context);
+ else
+ at86rf230_tx_on(context);
}
static void
--
2.2.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH bluetooth-next RESEND] at86rf230: cleanup check on trac status
2014-12-19 9:36 [PATCH bluetooth-next RESEND] at86rf230: cleanup check on trac status Alexander Aring
@ 2014-12-19 10:57 ` Marcel Holtmann
2014-12-19 11:02 ` Alexander Aring
0 siblings, 1 reply; 3+ messages in thread
From: Marcel Holtmann @ 2014-12-19 10:57 UTC (permalink / raw)
To: Alexander Aring; +Cc: linux-wpan, kernel
Hi Alex,
> Signed-off-by: Alexander Aring <alex.aring@gmail.com>
> Reviewed-by: Stefan Schmidt <s.schmidt@samsung.com>
> ---
> drivers/net/ieee802154/at86rf230.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
patch has been applied to bluetooth-next tree.
I would however prefer that even these small patches get a commit message explaining why that is correct and now was wrong before. Does not have to be anything big, but at least some sort of commit message body clearly explaining it would be helpful.
Regards
Marcel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH bluetooth-next RESEND] at86rf230: cleanup check on trac status
2014-12-19 10:57 ` Marcel Holtmann
@ 2014-12-19 11:02 ` Alexander Aring
0 siblings, 0 replies; 3+ messages in thread
From: Alexander Aring @ 2014-12-19 11:02 UTC (permalink / raw)
To: Marcel Holtmann; +Cc: linux-wpan, kernel
On Fri, Dec 19, 2014 at 11:57:24AM +0100, Marcel Holtmann wrote:
> Hi Alex,
>
> > Signed-off-by: Alexander Aring <alex.aring@gmail.com>
> > Reviewed-by: Stefan Schmidt <s.schmidt@samsung.com>
> > ---
> > drivers/net/ieee802154/at86rf230.c | 8 +++-----
> > 1 file changed, 3 insertions(+), 5 deletions(-)
>
> patch has been applied to bluetooth-next tree.
>
> I would however prefer that even these small patches get a commit message explaining why that is correct and now was wrong before. Does not have to be anything big, but at least some sort of commit message body clearly explaining it would be helpful.
>
Okay, thanks.
I need to admit that writing commit messages in some cases is more work than
to write the programming changes.
Nevertheless I will try to change that.
- Alex
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-12-19 11:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-19 9:36 [PATCH bluetooth-next RESEND] at86rf230: cleanup check on trac status Alexander Aring
2014-12-19 10:57 ` Marcel Holtmann
2014-12-19 11:02 ` Alexander Aring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).