From: Alexander Aring <alex.aring@gmail.com>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: linux-wpan@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH bluetooth-next 3/3] at86rf230: fix is_tx while error handling
Date: Thu, 26 Mar 2015 13:06:24 +0100 [thread overview]
Message-ID: <20150326120620.GB5394@omega> (raw)
In-Reply-To: <5513F38B.30007@pengutronix.de>
On Thu, Mar 26, 2015 at 12:54:51PM +0100, Marc Kleine-Budde wrote:
> On 03/26/2015 12:46 PM, Alexander Aring wrote:
> > This patch fix the error handling when is_tx is true. The error handling
> > tries to get the transceiver into RX_AACK_ON mode then we need to be
> > sure that is_tx is false.
>
> Generally speaking, first fix errors, then clean up and improve code.
>
should I resend again with a new sequence of this patch series?
I know it's some mixed things which I detect while hacking the nl802154
crypto foo. But I will remember Marc's words before sending next series.
:-)
btw:
I think if an spi_async error occurs then something goes really wrong
and a rescue by doing a TRX_OFF -> RX_AACK_ON doesn't help also anymore.
We need then something like rf_kill framework.
- Alex
next prev parent reply other threads:[~2015-03-26 12:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-26 11:46 [PATCH bluetooth-next 1/3] mac802154: cleanup concurrent check Alexander Aring
2015-03-26 11:46 ` [PATCH bluetooth-next 2/3] at86rf230: remove unnecessary spinlock Alexander Aring
2015-03-27 18:22 ` Marcel Holtmann
2015-03-26 11:46 ` [PATCH bluetooth-next 3/3] at86rf230: fix is_tx while error handling Alexander Aring
2015-03-26 11:54 ` Marc Kleine-Budde
2015-03-26 12:06 ` Alexander Aring [this message]
2015-03-26 15:01 ` Marcel Holtmann
2015-03-27 18:22 ` Marcel Holtmann
2015-03-27 18:22 ` [PATCH bluetooth-next 1/3] mac802154: cleanup concurrent check Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150326120620.GB5394@omega \
--to=alex.aring@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-wpan@vger.kernel.org \
--cc=mkl@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox