Re: [PATCHv3 bluetooth-next 2/4] nl802154: add set interface cmd

[Alexander Aring <alex.aring@gmail.com>]

On Tue, Apr 07, 2015 at 03:32:13PM +0200, Phoebe Buckheister wrote:
> 
> Eh? No.
> 

Okay. :-)

> struct wpan_phy_support {
> 	bool lbt, aack;

for aack I would use max and min for frame_retries (need to be signed
integer) and the same logik like max_frame_retries parameter in driver
ops. So if s8 max_frame_retries and min_frame_retries -1 then we don't
support aack handling. 

> 	u16 min_be, max_be;

I think for the backoff exponents we need something like:

min_minbe and max_minbe

and

min_maxbe and max_maxbe

sounds a little bit ugly, but some transceivers can't change the maxbe
value.

> 	u32 pages;
> 	u32 channels[32];

This is already combined in channels_supported array for pages and channels.

> };
> 
> or something like that. A complete description of PHY capabilities, we
> might even export that to userspace somehow?
> 

yes, of course. I think we should implement then a nested nl attribute for
wpan_phy_supported things while wpan_phy dump.

- Alex