Re: [PATCH] ieee802154: Add trace events for rdev->ops

[Alexander Aring <alex.aring@gmail.com>]

Hi,

On Sun, Apr 12, 2015 at 02:07:33PM +0200, Guido Günther wrote:
> This is based on the rdev->ops tracing code from net/wireless/.
> 

this patch looks good. I tested it with trace-cmd:

1. trace-cmd record -e cfg802154:802154_rdev_set_pan_id

2. iwpan dev wpan0 set pan_id 0xbeaa

3. trace-cmd report

result:

version = 6
cpus=1
           iwpan-1266  [000]   892.921639: 802154_rdev_set_pan_id: phy0, wpan_dev(1), pan id: 0xbeaa

also test it with channel and it works pretty well. (I am not a
trace-cmd export at the moment, my previous use-case was enough to use
the raw ftrace interface).


I looked again for the byteorder handling and detected that trace-cmd has
a cfg802154 plugin [0]. It looks like the plugin is there, to doing
byteorder translation in userspace instead kernelspace.

Looking into "__le16_to_cpup" stuff in wireless trace.h show something
like [1].

Do you think we can do this in the same way? Then we need some
plugin_cfg802154 in trace-cmd tool.

- Alex

[0] http://git.kernel.org/cgit/linux/kernel/git/rostedt/trace-cmd.git/tree/plugin_cfg80211.c
[1] http://lxr.free-electrons.com/source/net/wireless/trace.h?v=3.19#L2160