From: Alexander Aring <alex.aring@gmail.com>
To: Christoffer Holmstedt <christoffer.holmstedt@gmail.com>
Cc: linux-wpan@vger.kernel.org
Subject: Re: First kernel patch - checkpatch for at86rf230.c, false-positives?
Date: Thu, 23 Apr 2015 14:08:36 +0200 [thread overview]
Message-ID: <20150423120835.GC9284@omega> (raw)
In-Reply-To: <CAG9Fz+tcYsL_iUp7eLHWMB8B9Qrmi7C4HG6ROffyxQzhJo8BNQ@mail.gmail.com>
On Thu, Apr 23, 2015 at 01:48:05PM +0200, Christoffer Holmstedt wrote:
> Yea, "breaking the ice" is what I need. So something like
> "TRX_STATE_MASK (0x1f)"?
yes or cleanup the style issue "tabs after define" in the SR/RG defines.
It's simple a search & replace in your editor with s/define\t/define /
in that range (that's how I fix it). I will remove it then in my branch.
... or running aspell on that file, I am sure I did several typos there.
That's what others linux developers also do, running some automatic code
checkers (also aspell), but there exist more outside cppcheck, rats,
spare etc. (Normally the maintainer should run this before each patch
and I try to do that).
- Alex
prev parent reply other threads:[~2015-04-23 12:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-23 9:48 First kernel patch - checkpatch for at86rf230.c, false-positives? Christoffer Holmstedt
2015-04-23 10:09 ` Alexander Aring
2015-04-23 10:25 ` Christoffer Holmstedt
2015-04-23 11:15 ` Alexander Aring
2015-04-23 11:48 ` Christoffer Holmstedt
2015-04-23 12:08 ` Alexander Aring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150423120835.GC9284@omega \
--to=alex.aring@gmail.com \
--cc=christoffer.holmstedt@gmail.com \
--cc=linux-wpan@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox