From: "Guido Günther" <agx@sigxcpu.org>
To: Alexander Aring <alex.aring@gmail.com>
Cc: linux-wpan@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH wpan-next] ieee802154: trace: fix endian convertion
Date: Wed, 29 Apr 2015 20:45:55 +0200 [thread overview]
Message-ID: <20150429184555.GA3572@bogon.m.sigxcpu.org> (raw)
In-Reply-To: <1430294781-22294-1-git-send-email-alex.aring@gmail.com>
On Wed, Apr 29, 2015 at 10:06:21AM +0200, Alexander Aring wrote:
> This patch fix endian convertions for extended address and short address
> handling when TP_printk is called.
>
> Signed-off-by: Alexander Aring <alex.aring@gmail.com>
> Cc: Guido Günther <agx@sigxcpu.org>
> ---
> net/ieee802154/trace.h | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/net/ieee802154/trace.h b/net/ieee802154/trace.h
> index 8ed9f97..5ac25eb 100644
> --- a/net/ieee802154/trace.h
> +++ b/net/ieee802154/trace.h
> @@ -58,7 +58,7 @@ TRACE_EVENT(802154_rdev_add_virtual_intf,
> ),
> TP_printk(WPAN_PHY_PR_FMT ", virtual intf name: %s, type: %d, ea %llx",
> WPAN_PHY_PR_ARG, __get_str(vir_intf_name), __entry->type,
> - __entry->extended_addr)
> + __le64_to_cpu(__entry->extended_addr))
> );
>
> TRACE_EVENT(802154_rdev_del_virtual_intf,
> @@ -138,7 +138,8 @@ DEFINE_EVENT_PRINT(802154_le16_template, 802154_rdev_set_short_addr,
> __le16 le16arg),
> TP_ARGS(wpan_phy, wpan_dev, le16arg),
> TP_printk(WPAN_PHY_PR_FMT ", " WPAN_DEV_PR_FMT ", sa: 0x%04x",
> - WPAN_PHY_PR_ARG, WPAN_DEV_PR_ARG, __entry->le16arg)
> + WPAN_PHY_PR_ARG, WPAN_DEV_PR_ARG,
> + __le16_to_cpu(__entry->le16arg))
> );
>
> TRACE_EVENT(802154_rdev_set_backoff_exponent,
Argh - missed that one. ACK.
Cheers,
-- Guido
prev parent reply other threads:[~2015-04-29 18:45 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-29 8:06 [PATCH wpan-next] ieee802154: trace: fix endian convertion Alexander Aring
2015-04-29 18:45 ` Guido Günther [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20150429184555.GA3572@bogon.m.sigxcpu.org \
--to=agx@sigxcpu.org \
--cc=alex.aring@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-wpan@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox