Linux IEEE 802.15.4 and 6LoWPAN development
 help / color / mirror / Atom feed
From: Alexander Aring <alex.aring@gmail.com>
To: Lennert Buytenhek <buytenh@wantstofly.org>
Cc: linux-wpan@vger.kernel.org
Subject: Re: [PATCH 1/8] ieee802154 socket: Return EMSGSIZE from raw_sendmsg() if packet too big.
Date: Wed, 20 May 2015 12:36:07 +0200	[thread overview]
Message-ID: <20150520103604.GF3978@omega> (raw)
In-Reply-To: <20150519194956.GM11014@wantstofly.org>

On Tue, May 19, 2015 at 10:49:56PM +0300, Lennert Buytenhek wrote:
> The proper return code for trying to send a packet that exceeds the
> outgoing interface's MTU is EMSGSIZE, not EINVAL, so patch ieee802154's
> raw_sendmsg() to do the right thing.  (Its dgram_sendmsg() was already
> returning EMSGSIZE for this case.)
> 
> Signed-off-by: Lennert Buytenhek <buytenh@wantstofly.org>

Nice, I never looked into the socket code deeper. But I think there are
several issues (from that what I read from the mailinglist.) I also put
it the opentasks section in wpan.cakelab.org that the socket code needs
a big rework/cleanup.

Acked-by: Alexander Aring <alex.aring@gmail.com>

- Alex

  reply	other threads:[~2015-05-20 10:36 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <cover.1432064518.git.buytenh@wantstofly.org>
2015-05-19 19:49 ` [PATCH 1/8] ieee802154 socket: Return EMSGSIZE from raw_sendmsg() if packet too big Lennert Buytenhek
2015-05-20 10:36   ` Alexander Aring [this message]
2015-05-19 19:50 ` [PATCH 2/8] Documentation/networking/ieee802154.txt: fix various inaccuracies Lennert Buytenhek
2015-05-19 22:05   ` Marcel Holtmann
2015-05-20  8:36     ` Lennert Buytenhek
2015-05-20  8:40       ` Stefan Schmidt
2015-05-20  8:54       ` Alexander Aring
2015-05-20  9:14         ` Lennert Buytenhek
2015-05-20  9:54       ` Marcel Holtmann
2015-05-20  8:36     ` Stefan Schmidt
2015-05-19 19:50 ` [PATCH 3/8] ieee802154: Remove ieee802154_reduced_mlme_ops references Lennert Buytenhek
2015-05-20 10:34   ` Alexander Aring
2015-05-19 19:50 ` [PATCH 4/8] ieee802154: Remove 802.15.4/6LoWPAN checks for interface MTU Lennert Buytenhek
2015-05-20 10:45   ` Alexander Aring
2015-05-19 19:50 ` [PATCH 5/8] ieee802154 6lowpan: Don't implement ieee802154_mlme_ops Lennert Buytenhek
2015-05-20 10:41   ` Alexander Aring
2015-05-25  6:17     ` Lennert Buytenhek
2015-05-19 19:50 ` [PATCH 6/8] ieee802154 socket: No need to check for ARPHRD_IEEE802154 in raw_bind() Lennert Buytenhek
2015-05-20 10:42   ` Alexander Aring
2015-05-19 19:50 ` [PATCH 7/8] mac802154: mac802154_header_create() optimisation Lennert Buytenhek
2015-05-20 10:33   ` Alexander Aring
2015-05-19 19:50 ` [PATCH 8/8] mac802154: mac802154_mlme_start_req() optimisation Lennert Buytenhek
2015-05-20 10:11   ` Alexander Aring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20150520103604.GF3978@omega \
    --to=alex.aring@gmail.com \
    --cc=buytenh@wantstofly.org \
    --cc=linux-wpan@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox