Re: [RFC bluetooth-next] mac802154: add trace functionality for driver ops

[Alexander Aring <alex.aring@gmail.com>]

On Fri, May 29, 2015 at 11:01:48AM +0530, Varka Bhadram wrote:
> Hi Alex,
> 
> On 05/28/2015 01:50 PM, Alexander Aring wrote:
> 
> >Hi,
> >
> >I did not test yet, but found some review things.
> 
> Please test it.
> 
> >On Wed, May 27, 2015 at 01:54:50PM +0530, Varka Bhadram wrote:
> >...
> >>+		__field(bool, mode)
> >>+	),
> >>+	TP_fast_assign(
> >>+		LOCAL_ASSIGN;
> >>+		__entry->mode = mode;
> >>+	),
> >>+	TP_printk(LOCAL_PR_FMT ", lbt mode: %s", LOCAL_PR_ARG,
> >>+		  BOOL_TO_STR(__entry->mode))
> >>+);
> >>+
> >>+TRACE_EVENT(802154_drv_set_short_addr,
> >>+	TP_PROTO(struct ieee802154_local *local, __le16 short_addr),
> >>+	TP_ARGS(local, short_addr),
> >>+	TP_STRUCT__entry(
> >>+		LOCAL_ENTRY
> >>+		__field(__le16, short_addr)
> >>+	),
> >>+	TP_fast_assign(
> >>+		LOCAL_ASSIGN;
> >>+		__entry->short_addr = short_addr;
> >>+	),
> >>+	TP_printk(LOCAL_PR_FMT ", sa: 0x%04x", LOCAL_PR_ARG,
> >>+		  __entry->short_addr)
> >care about byteorder here. you need cpu_to_le16 in the format string,
> >please.
> >
> >

meant s/cpu_to_le16/le16_to_cpu/

- Alex