Re: [PATCH atusb/fw 2/2] atusb: fw: Provide TRAC status

[Miquel Raynal <miquel.raynal@bootlin.com>]

Hi Alexander,

aahringo@redhat.com wrote on Mon, 5 Sep 2022 20:19:28 -0400:

> Hi,
> 
> On Mon, Sep 5, 2022 at 8:16 PM Alexander Aring <aahringo@redhat.com> wrote:
> >
> > Hi,
> >
> > On Mon, Sep 5, 2022 at 4:43 PM Miquel Raynal <miquel.raynal@bootlin.com> wrote:  
> > >
> > > From: Alexander Aring <aahringo@redhat.com>
> > >
> > > Upon Tx done condition, returning the sequence number is useful but we
> > > might also return the TRAC value which is needed to ensure that the
> > > packet we sent got ACKed. The TRAC register just needs to be read when
> > > the TRX_END interrupt fires.
> > >
> > > We then need to send this information as part of the status
> > > message. First byte remains the sequence number for ensuring backward
> > > compatibility and a second byte is added to forward the TRAC register
> > > status.
> > >
> > > Signed-off-by: Alexander Aring <aahringo@redhat.com>
> > > [Miquel Raynal: Moved the data array out of the stack, wrote commit log]
> > > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com>  
> >
> > I sent another patch v2, it should also fix a race see commit msg
> > regarding RX_AACK_ON. May you can fast test it and feel welcome to
> > resubmit it as a patch.
> > This patch has a lot of generated/compiled files added and I think it
> > was an accident.  

Crap.

> there are files which need to be added to ".gitignore". Just a hint,
> run "git add -u ." instead of "git add ." which will not add new
> files.

I didn't know about -u, I should probably get used to it because I too
often send generated files by mistake...

I initially wanted to add a .gitignore, and then forgot. I'll do it.

Thanks,
Miquèl