From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj2-f13.google.com (mail-pj2-f13.google.com [74.125.227.141]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CA65843C05E for ; Mon, 21 Sep 2026 07:42:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.141 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789976528; cv=none; b=dZ7s1pGfmigd59rn8XgyzSmSjR1KGfX51FKke2jIVChPmcA3arqWXWzhQn1zOYBo2+xaRl3b/InHVR7Q8TB7wXaLt8tbpN/uwYuxNMNNvBcvHaECiBWgFfy4SXWuT+leLejFkPnrgqC2q4z68tWAEdzQkOUNh19UwC8wBseOVME= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1789976528; c=relaxed/simple; bh=YpyUyxCo507Mg3FfSIChnx0hchuXkpf1IYcucI+jCnE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=SqPP5g0eRBJdKAsfIDchWSzZpBFoO9y0FW35lwbTYJB8JfuxGz7jVP57yHlBU7Q8m2UjZsOEToDVWxSo6V15yMyA876pi8NTlaBbgu0oH+Rd+9A1ALSHHx5eUOhDTMAEF2091wBAS3P15alAwF5jEqqcK9M7/Lvld024X5ApG/Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=qqe+lclB; arc=none smtp.client-ip=74.125.227.141 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qqe+lclB" Received: by mail-pj2-f13.google.com with SMTP id 98e67ed59e1d1-396ccda24a3so1973814a91.0 for ; Mon, 21 Sep 2026 00:42:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1789976526; x=1790581326; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=r+ECARSANJrUe2ZD7obBA7E5y8RycSAtQslnQO+mgvc=; b=qqe+lclBJb1rqSKhljacPsLAQQB9CrIzTdz9rVjqy3nmHMYP1cVYKqlL/o6DscJBdS YcH5uPgiEYyg8ygMLcF9FkqMycohG7XNkqyzE1ps1scI+jSe/M6KMdSMaqig1iQYE/2T NDXqct80WAVrgXtYG46f+0F5dXfJlL4EItKAm2vZ0+AcMBYaX7Ft6f/Vs1h0ZP83Ly1J wKLvduSXgZpDrWi5hbHLnhSgdb9jAydl/x8vYfpDZax70yrkwn8YrUgamZzRSMV0WTlf onlkr34+utbZIPGAcVczJ8aeKyzzlKsLfdP8inAVt9hcNwYnVZZLURW1pihW9H4ahVwy yYmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1789976526; x=1790581326; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=r+ECARSANJrUe2ZD7obBA7E5y8RycSAtQslnQO+mgvc=; b=KQ9c1YFsQ/sEWqYsY48GJMnXDui/vFBxoL23JaQXWCMLysbJhg463XCQdKlHymVVtJ JvOiLT0eJT9DmWG5VROhvg8nEi1OpToBnfqc8uIbuszCeyOCu/f+DP4INjBA5ErSjgCr pXqx3aMyYP9BhUcU2PMU41KI8TeytHaBWKu84AcNDwfVrMY3PL8WKfnx9Szxn3qKCn22 G7WUCxhFcFyp01qNzDmPI4T6phZ5cQ1Hy+K+5yyUquOnveA6ZdAAwXwxD+lLii9DZl1b UP8/czbdBFVm7oc9HoZkR6TUBla4zV7qtfE7ark9Yq5eks0M0MsJt2XXryK//6KqEq7V dfcw== X-Gm-Message-State: AFuF++mPHmriR/H8LmB6VyalZUK2QdkR/Mvv57N3T+I2bvbeNHucLbHw ODTCSYnAjEOH6O1k25VCC5PJ2hlbfSW7lNQKHpSDg5jqo0Tzac+46Pug X-Gm-Gg: AYBFou2NUbj0gpaqI85oi2Er2iYDFnDb7U3KV51ruuIbaL9oxJHrDFR2sS+3pUgW6td XaOAQx8Zb2pzAzdgVlUooNgBuYIVrwZtjoU2naam9fce4RUhF93+3hYKMwrdMutxOssOmtMCrT5 pM8yPo+Pl65KXi58ixOZi1SjimRBZMUr+vhhB2cRUBvD78Pj9lFCZqtMP+aeZ0Ufl2UT7xQIUf+ dHjyDEfahor47rgQ0TuSckamF8aiqEEz0zwgr/uwwJYwZDfnV7M119+5fgVH2IEQb7a2sTTh8bB YwPA2eWHsUqU/2+cbID1NtUDTy+zbH3cax7QHfCvKrPnTtIapOqDqVbmzMhY6m0ZQKusUzHMF6m 7aIitl2VYymPxkBg9RBOCtaiTb3SRJF/IXcLOPEX7SNOVXCQlZn3/l7wK0EtkHssCgvkTSPNl76 m7S+v6gPOzKO2W3BBSrmBJFBo0lUn056erU7rzJWihf6TawgTUMi7GLa+9417sNd5b9B3xeOeRs XdN48YijIHIG0PQjyA+Nojpa7WRvPgLQFWiEez09KnoWAB00qgMy0acktDK0xvxXVPXhUSG/4Rz fcKlSXYU6Q== X-Received: by 2002:a17:90a:6c82:b0:39e:6a81:c923 with SMTP id 98e67ed59e1d1-39e6a81c9admr6628207a91.22.1789976526137; Mon, 21 Sep 2026 00:42:06 -0700 (PDT) Received: from phui-2.c.googlers.com.com (78.123.83.34.bc.googleusercontent.com. [34.83.123.78]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-39e6cabb771sm13015876a91.9.2026.09.21.00.42.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 21 Sep 2026 00:42:05 -0700 (PDT) From: Hui Peng To: Harry Morris , Alexander Aring , Miquel Raynal , Stefan Schmidt Cc: linux-wpan@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Hui Peng , stable@vger.kernel.org Subject: [PATCH net v2 1/3] ieee802154: ca8210: prevent stack buffer overflow in ca8210_rx_done() Date: Mon, 21 Sep 2026 07:42:03 +0000 Message-ID: <20260921074205.2289211-1-benquike@gmail.com> X-Mailer: git-send-email 2.55.0.1082.g2b9226bbc0-goog In-Reply-To: <20260919213637.3316595-1-benquike@gmail.com> References: <20260919213637.3316595-1-benquike@gmail.com> Precedence: bulk X-Mailing-List: linux-wpan@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In ca8210_rx_done(), the packet length len = buf[1] + 2 is only checked against CA8210_SPI_BUF_SIZE (256). When buf[0] & SPI_SYN is set and priv->sync_command_response is non-NULL, memcpy() copies up to 256 bytes into priv->sync_command_response, which points to a struct mac_message object (sizeof(struct mac_message) = 250 bytes) on the synchronous caller's stack, overflowing the stack buffer by up to 6 bytes: BUG: KASAN: stack-out-of-bounds in ca8210_rx_done+0xc4/0xe0 Write of size 256 at addr ffff888001907660 by task init/1 Call Trace: dump_stack_lvl+0x70/0xa0 print_report+0x153/0x4c6 kasan_report+0xf1/0x120 kasan_check_range+0x125/0x200 __asan_memcpy+0x3c/0x60 ca8210_rx_done+0xc4/0xe0 ca8210_spi_exchange+0x12e/0x190 ... The buggy address belongs to stack of task init/1 and is located at offset 32 in frame: ca8210_spi_exchange+0x0/0x190 This frame has 1 object: [32, 282) 'response' Bound the synchronous response memcpy() length to min_t(size_t, len, sizeof(struct mac_message)). Tested in QEMU with KASAN enabled by passing a 256-byte SPI_SYN response into ca8210_rx_done(). Fixes: ded845a781a5 ("ieee802154: Add CA8210 IEEE 802.15.4 device driver") Cc: stable@vger.kernel.org Assisted-by: LLM Signed-off-by: Hui Peng --- Changes in v2: - Split the ca8210 fixes into three single-issue patches (1/3..3/3). drivers/net/ieee802154/ca8210.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ieee802154/ca8210.c b/drivers/net/ieee802154/ca8210.c index 01af4f9..c009930 100644 --- a/drivers/net/ieee802154/ca8210.c +++ b/drivers/net/ieee802154/ca8210.c @@ -697,7 +697,8 @@ static void ca8210_rx_done(struct cas_control *cas_ctl) if (buf[0] & SPI_SYN) { if (priv->sync_command_response) { - memcpy(priv->sync_command_response, buf, len); + memcpy(priv->sync_command_response, buf, + min_t(size_t, len, sizeof(struct mac_message))); complete(&priv->sync_exchange_complete); } else { if (cascoda_api_upstream) -- 2.47.3