From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj2-f38.google.com (mail-pj2-f38.google.com [74.125.227.166]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C355D44CF29 for ; Wed, 30 Sep 2026 07:19:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.227.166 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790752759; cv=none; b=F//2DCoxJatcF1OqjKuLLTI8VBTme/WCQkbYA6BRm2i/u/AwGsUyIFPVozlmTQbMZEDmnmAeg/nvMkTBZNpgF3xyYG7VGmxmPDvLdjFoQ2bx5LIQMzq5gNROXtyViewq7VWopvLr6o6HTaLJUDJy7K9XHA/VnWqqyAYWvInoALU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790752759; c=relaxed/simple; bh=aJVsoy5Trk1oVXSy6lO13HBYy2aSxZSVKLzYy8qqiKE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Z/q9JE9Xc2XcsMZHu1WIVGMr14z82jYtHRBbvJi7QwGJqd6zayujH3YdQNrFnWemxHeFXLDgblywPCOtQVlgaL3gmI7NsB5f/0xarpEJa66JHhAQZkqaCrwvGmyXYJQz70sdnlhZVXRyJ86eb0x3VK9mTecwTL1sfC7y3SpgrEk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=HcCAB3cU; arc=none smtp.client-ip=74.125.227.166 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="HcCAB3cU" Received: by mail-pj2-f38.google.com with SMTP id 98e67ed59e1d1-3a4c0da0145so284086a91.0 for ; Wed, 30 Sep 2026 00:19:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1790752757; x=1791357557; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to:content-type; bh=CtXRhGuw2qVKHIOiXDCs7JborWUyDWhbjStFj79j+rc=; b=HcCAB3cU+UouU2Vh+4JuDZ1pjHM5Ba62oUWGDj+nGEeXw3iLRSwv4uUmA1yUj5tLY0 4B6AUdrKPk4977leORDoQS4T73H5y4bjxuUvwteLQSciU0mdkIgo1F+gVSEZfeg+NNLQ P4CtAfxfG+iuidcokb5r2zO68rbWe9A75hn9wZ6jmOGMsuzjb6DmqsOiUxFeiJLxBK7J HW3s1wanYjCb5Ge5ZP5opgqTUjyi1SncMKFBoFleUmBkl4aQTkpPzKh9TeEkSW20Bdgb QsIc6jlSkLdtE5GiVvlADm50LKA9AIyaCGY+Om4IQyyS66d7PUaG4qVdrK6pGn3VvJqq R0aA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790752757; x=1791357557; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to:content-type; bh=CtXRhGuw2qVKHIOiXDCs7JborWUyDWhbjStFj79j+rc=; b=xhhkuMBhI9Jb/MJiydHjWpa0TN5h1A3cC8FBgTF8Z1a5N8/ZnboWTZrFQ13FYxmWzR 1GQbuPdx8yEiQnnj7+vrGBRV/bPS4DPHGx9twoVZyvsww0UcFSKKuw2hR0kPexCx9sw1 rI10G/Ll4EVTwdij2LxefAuZmtYL1+C2lMqMNIGoOmCeIBI2MWdRbndmqgta572ena5c eyDS3py+DJz5tdw/78knGQa2CiMGXwczrXCWECn1h3tIB9kOF6zuRKtmJJiAwHeTHkTh S1l9KdkG7xXyGV27MfPq9EFdcECpli1jFk9jM5BpnRbn0KmlL22g5srGMpv7bX3ql8ws p3sw== X-Forwarded-Encrypted: i=1; AKwUvByyXgpvlFo6I6vz3S8b4S6jw0JbR2F/HXG6cugAlL/ja0LqTrhi63iyiJWwVUPjr7e/sygVgDueP2eu@vger.kernel.org X-Gm-Message-State: AFq9FYJo/jkrShaOYY88PVqFqtemBnlKfTf4qVxCGI8guBjxFkTr9PXg 6QKxSgXruDwK8J0TNNy7Aoyo764svINnrmc8sF4gcBcAaQd8tQmrsM2j X-Gm-Gg: AYBFou2aAiwD7v/EaQ4Itx+iWmWHzCQYsNf2L9JBrtZF75UssOKkawkZZGbexiCYClZ Q7sdo9R32es74tI1xBYXnaYilz+G9iUTrHY0vmQ6GtEPacbxIkqG2u2WmPzUwhYvQ5sNrSn//y+ Yo1S79VmMjqmkglYZODNW5XjRarDww9Ut58jg6rYxRKEnIh0b8WNXrXav2QDZGUvYEB5nGQVRtk NbhUxHtMnM6hA6Ou6lAKJl5eGcsJ0ROLFxKJZlr3W/X7slgI/dJQFc4VhpFi0+L3PRD4JaKUvXU QL97+KXQeh4dAogZrHPTFyzZ9iLJNmt2Bfu7KDlobAiD/wJXAYaFPu8ytOdHansNfUOUKTXAQb9 nV4kxJKP+FZ0GV3UO7JB83H/FRVB4bXVFf8uCoIIIl2/vcCHlK5vAvDRuZSoFHQxaaEuGaxGBuZ nat/Upu2y/tqpecaejLRGSJnK/nESur9XnuV4W3SgZxpTDH/DA5KkkUJXgLyCSuYj8CVgh06HtD P22S2WjEI5KR2eMagjCucahSuSBIKT3ZtlwhMU50maq0xSyPjLCSfYFkjYKHF/szdwt2+mWH4lW KWEQVGEZhVe+v5rV7jyO X-Received: by 2002:a17:90b:4fd0:b0:3a4:a3e8:22ff with SMTP id 98e67ed59e1d1-3a4d1509d56mr448821a91.19.1790752756998; Wed, 30 Sep 2026 00:19:16 -0700 (PDT) Received: from phui-2.c.googlers.com.com (25.187.82.34.bc.googleusercontent.com. [34.82.187.25]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3a4caec0f28sm2256687a91.17.2026.09.30.00.19.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 30 Sep 2026 00:19:16 -0700 (PDT) From: Hui Peng To: Harry Morris , Alexander Aring , Miquel Raynal , Stefan Schmidt Cc: David Laight , linux-wpan@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Hui Peng Subject: [PATCH net v3 1/3] ieee802154: ca8210: prevent stack buffer overflow in ca8210_rx_done() Date: Wed, 30 Sep 2026 07:19:12 +0000 Message-ID: <20260930071914.421586-2-benquike@gmail.com> X-Mailer: git-send-email 2.56.0.rc1.315.gc6ed9934b7-goog In-Reply-To: <20260930071914.421586-1-benquike@gmail.com> References: <20260930071914.421586-1-benquike@gmail.com> Precedence: bulk X-Mailing-List: linux-wpan@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In ca8210_spi_transfer(), each SPI transfer reads sizeof(struct mac_message) bytes into cas_ctl->tx_in_buf: cas_ctl->transfer.len = sizeof(struct mac_message); However, ca8210_rx_done() only checks the received packet length len = buf[1] + 2 against CA8210_SPI_BUF_SIZE (256). When buf[0] & SPI_SYN is set and priv->sync_command_response is non-NULL, memcpy() copies up to 256 bytes into priv->sync_command_response, which points to a struct mac_message object on the synchronous caller's stack, overflowing the stack buffer: BUG: KASAN: stack-out-of-bounds in ca8210_rx_done+0x117/0x6c0 Write of size 256 at addr ffff8881009e7c40 by task swapper/0/1 Call Trace: dump_stack_lvl+0x70/0xa0 print_report+0x153/0x4c6 kasan_report+0xf1/0x120 kasan_check_range+0x125/0x200 __asan_memcpy+0x3c/0x60 ca8210_rx_done+0x117/0x6c0 ... This frame has 1 object: [32, 182) 'response' Check len > sizeof(struct mac_message) instead of len > CA8210_SPI_BUF_SIZE in ca8210_rx_done() so that any packet exceeding sizeof(struct mac_message) is logged as erroneously long via dev_crit() and dropped before copying into priv->sync_command_response or passing it to ca8210_net_rx(). Tested in QEMU with KASAN enabled by passing a 256-byte SPI_SYN response into ca8210_rx_done(). Fixes: ded845a781a5 ("ieee802154: Add CA8210 IEEE 802.15.4 device driver") Cc: stable@vger.kernel.org Assisted-by: LLM Signed-off-by: Hui Peng --- Changes in v3: - Check len > sizeof(struct mac_message) at the top of ca8210_rx_done() where dev_crit() logs the error and drops the packet instead of silently truncating memcpy() with min_t(), addressing David Laight's feedback. Changes in v2: - Split the ca8210 fixes into three single-issue patches (1/3..3/3). drivers/net/ieee802154/ca8210.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ieee802154/ca8210.c b/drivers/net/ieee802154/ca8210.c index 01af4f9..a990a0f 100644 --- a/drivers/net/ieee802154/ca8210.c +++ b/drivers/net/ieee802154/ca8210.c @@ -686,7 +686,7 @@ static void ca8210_rx_done(struct cas_control *cas_ctl) buf = cas_ctl->tx_in_buf; len = buf[1] + 2; - if (len > CA8210_SPI_BUF_SIZE) { + if (len > sizeof(struct mac_message)) { dev_crit( &priv->spi->dev, "Received packet len (%u) erroneously long\n", -- 2.49.0