From: Stefan Schmidt <s.schmidt@samsung.com>
To: 'Varka Bhadram' <varkabhadram@gmail.com>, linux-wpan@vger.kernel.org
Cc: alex.aring@gmail.com, 'Varka Bhadram' <varkab@cdac.in>
Subject: Re: [PATCH bluetooth-next 1/2] mac802154: use goto label on failure
Date: Fri, 05 Dec 2014 12:03:42 +0000 [thread overview]
Message-ID: <20dc01d01083$83dc56c0$8b950440$@samsung.com> (raw)
In-Reply-To: <1417780150-4033-1-git-send-email-varkab@cdac.in>
Hello.
On 05/12/14 12:49, Varka Bhadram wrote:
> Signed-off-by: Varka Bhadram <varkab@cdac.in>
> ---
> net/mac802154/rx.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/net/mac802154/rx.c b/net/mac802154/rx.c
> index 041dbd5..c0d67b2 100644
> --- a/net/mac802154/rx.c
> +++ b/net/mac802154/rx.c
> @@ -85,8 +85,7 @@ ieee802154_subif_frame(struct ieee802154_sub_if_data
> *sdata,
> default:
> spin_unlock_bh(&sdata->mib_lock);
> pr_debug("invalid dest mode\n");
> - kfree_skb(skb);
> - return NET_RX_DROP;
> + goto fail;
> }
>
> spin_unlock_bh(&sdata->mib_lock);
>
Good catch!
Reviewed-by: Stefan Schmidt <s.schmidt@samsung.com>
regards
Stefan Schmidt
next prev parent reply other threads:[~2014-12-05 12:04 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-05 11:49 [PATCH bluetooth-next 1/2] mac802154: use goto label on failure Varka Bhadram
2014-12-05 11:49 ` [PATCH bluetooth-next 2/2] cc2520: adds terminating newline Varka Bhadram
2014-12-05 13:19 ` Marcel Holtmann
2014-12-05 12:03 ` Stefan Schmidt [this message]
2014-12-05 12:31 ` [PATCH bluetooth-next 1/2] mac802154: use goto label on failure Alexander Aring
2014-12-05 13:19 ` Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='20dc01d01083$83dc56c0$8b950440$@samsung.com' \
--to=s.schmidt@samsung.com \
--cc=alex.aring@gmail.com \
--cc=linux-wpan@vger.kernel.org \
--cc=varkab@cdac.in \
--cc=varkabhadram@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox