Re: [PATCH] at86rf230: remove version check for AT86RF212

[Stefan Schmidt <s.schmidt@samsung.com>]

Hello.

On 12/12/14 00:11, Andrey Yurovsky wrote:
> From: Andrey Yurovsky <yurovsky@gmail.com>
>
> This version check allows the driver to only work with v1 hardware
> however there is no driver-facing difference with newer versions
> (confirmed by Atmel FAEs) so this check needlessly prevents the driver
> from being used with radios now in production.

Has anyone tested the driver with this new hardware yet? Or are the 
productions so early that there are now samples yet?

> Signed-off-by: Andrey Yurovsky <yurovsky@gmail.com>
> ---
>   drivers/net/ieee802154/at86rf230.c | 16 ++++++----------
>   1 file changed, 6 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/net/ieee802154/at86rf230.c
> b/drivers/net/ieee802154/at86rf230.c
> index 1c01356..007470f 100644
> --- a/drivers/net/ieee802154/at86rf230.c
> +++ b/drivers/net/ieee802154/at86rf230.c
> @@ -1429,16 +1429,12 @@ at86rf230_detect_device(struct at86rf230_local
> *lp)
>   		break;
>   	case 7:
>   		chip = "at86rf212";
> -		if (version == 1) {
> -			lp->data = &at86rf212_data;
> -			lp->hw->flags |= IEEE802154_HW_LBT;
> -			lp->hw->phy->channels_supported[0] = 0x00007FF;
> -			lp->hw->phy->channels_supported[2] = 0x00007FF;
> -			lp->hw->phy->current_channel = 5;
> -			lp->hw->phy->symbol_duration = 25;
> -		} else {
> -			rc = -ENOTSUPP;
> -		}
> +		lp->data = &at86rf212_data;
> +		lp->hw->flags |= IEEE802154_HW_LBT;
> +		lp->hw->phy->channels_supported[0] = 0x00007FF;
> +		lp->hw->phy->channels_supported[2] = 0x00007FF;
> +		lp->hw->phy->current_channel = 5;
> +		lp->hw->phy->symbol_duration = 25;
>   		break;
>   	case 11:
>   		chip = "at86rf233";
>

Change looks good.

Reviewed-by: Stefan Schmidt <s.schmidt@samsung.com>

regards
Stefan Schmidt