From: Stefan Schmidt <s.schmidt@samsung.com>
To: 'Alexander Aring' <alex.aring@gmail.com>, linux-wpan@vger.kernel.org
Cc: kernel@pengutronix.de
Subject: Re: [PATCHv2 bluetooth-next 1/5] at86rf230: remove if branch
Date: Mon, 15 Dec 2014 09:34:02 +0000 [thread overview]
Message-ID: <250d01d0184a$43390040$c9ab00c0$@samsung.com> (raw)
In-Reply-To: <1418635557-6670-2-git-send-email-alex.aring@gmail.com>
Hello.
On 15/12/14 10:25, Alexander Aring wrote:
> This patch removes an unnecessary if branch inside the tx complete
> handler.
>
> Signed-off-by: Alexander Aring <alex.aring@gmail.com>
> ---
> drivers/net/ieee802154/at86rf230.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/net/ieee802154/at86rf230.c
> b/drivers/net/ieee802154/at86rf230.c
> index 1c01356..434efc5 100644
> --- a/drivers/net/ieee802154/at86rf230.c
> +++ b/drivers/net/ieee802154/at86rf230.c
> @@ -715,10 +715,7 @@ at86rf230_tx_complete(void *context)
>
> enable_irq(lp->spi->irq);
>
> - if (lp->max_frame_retries <= 0)
> - ieee802154_xmit_complete(lp->hw, skb, true);
> - else
> - ieee802154_xmit_complete(lp->hw, skb, false);
> + ieee802154_xmit_complete(lp->hw, skb, !lp->tx_aret);
> }
>
> static void
>
Thanks!
Reviewed-by: Stefan Schmidt <s.schmidt@samsung.com>
regards
Stefan Schmidt
next prev parent reply other threads:[~2014-12-15 9:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-15 9:25 [PATCHv2 bluetooth-next 0/5] at86rf230: cleanups Alexander Aring
2014-12-15 9:25 ` [PATCHv2 bluetooth-next 1/5] at86rf230: remove if branch Alexander Aring
2014-12-15 9:34 ` Stefan Schmidt [this message]
2014-12-15 9:25 ` [PATCHv2 bluetooth-next 2/5] at86rf230: make at86rf230_async_error inline Alexander Aring
2014-12-15 9:25 ` [PATCHv2 bluetooth-next 3/5] at86rf230: fix context pointer handling Alexander Aring
2014-12-15 9:25 ` [PATCHv2 bluetooth-next 4/5] at86rf230: cleanup check on trac status Alexander Aring
2014-12-15 9:25 ` [PATCHv2 bluetooth-next 5/5] at86rf230: remove unnecessary assign Alexander Aring
2014-12-18 23:21 ` [PATCHv2 bluetooth-next 0/5] at86rf230: cleanups Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='250d01d0184a$43390040$c9ab00c0$@samsung.com' \
--to=s.schmidt@samsung.com \
--cc=alex.aring@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-wpan@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox