From: Alan Ott <alan@signal11.us>
To: Alexander Aring <alex.aring@gmail.com>,
Walter Mack <wmack@componentsw.com>
Cc: linux-wpan@vger.kernel.org, simon.vincent@xsilon.com
Subject: Re: [PATCH wpan-next] ieee802154: mrf24j40: support for external rx/tx
Date: Mon, 22 Sep 2014 23:51:43 -0400 [thread overview]
Message-ID: <5420EE4F.5000007@signal11.us> (raw)
In-Reply-To: <20140916202000.GF6104@omega>
On 09/16/2014 04:20 PM, Alexander Aring wrote:
> Hi Walter,
>
> On Tue, Sep 16, 2014 at 01:13:12PM -0700, Walter Mack wrote:
>> Alex,
>>
>> this is not a question of chip revisions. Chips with the same revision can
>> be used in designs with or without the external transmitter/receiver. Its
>> just that the chip has to be set up to be compatible with the design.
>>
> ah, ok. Dunno, I will wait on alan's opinion. If I don't heard anything in one
> week I will apply it.
Did Simon's patch get applied? I couldn't see it in any of the obvious
places when I looked the other day.
>
> Maybe alan wants also add a device tree support for this driver and then we could
> make a dt property/platform data for that. But for now, I am also fine with module
> parameter solution... because we don't have a dt support right now.
>
I don't like this as a module parameter. That's not what module params
are really designed for. It's better as DT so that it can be turned on
and off for the individual devices, not system-wide.
mrf24j40 loads up fine under DT. There just isn't anything to configure
(so far) other than the SPI.
Are there any other known boards which use the external amplifier
besides the MB and MC (and MD and ME, which are the same as the MB and MC)?
Alex, I'm not sure how this fits with Simon's patch, as I haven't
investigated it fully. I'd expect both implementations to be the same,
but they're not.
Alan.
next prev parent reply other threads:[~2014-09-23 3:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-15 5:35 [PATCH wpan-next] ieee802154: mrf24j40: support for external rx/tx Walter Mack
2014-09-16 7:01 ` Alexander Aring
2014-09-16 20:13 ` Walter Mack
2014-09-16 20:20 ` Alexander Aring
2014-09-23 3:51 ` Alan Ott [this message]
2014-09-23 7:19 ` Alexander Aring
2014-09-23 7:58 ` Simon Vincent
2014-09-23 8:06 ` Alexander Aring
2014-09-24 6:11 ` Walter Mack
2014-09-24 6:35 ` Alexander Aring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5420EE4F.5000007@signal11.us \
--to=alan@signal11.us \
--cc=alex.aring@gmail.com \
--cc=linux-wpan@vger.kernel.org \
--cc=simon.vincent@xsilon.com \
--cc=wmack@componentsw.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox