From: Martin Townsend <martin.townsend@xsilon.com>
To: Jukka Rissanen <jukka.rissanen@linux.intel.com>
Cc: linux-bluetooth@vger.kernel.org, linux-wpan@vger.kernel.org,
marcel@holtmann.org, alex.aring@gmail.com
Subject: Re: [PATCH bluetooth-next] 6lowpan: Use pskb_expand_head in IPHC decompression.
Date: Wed, 08 Oct 2014 14:42:48 +0100 [thread overview]
Message-ID: <54353F58.4090301@xsilon.com> (raw)
In-Reply-To: <1412775335.2705.31.camel@jrissane-mobl.ger.corp.intel.com>
hi Jukka,
Thank you for running all these tests for me, it's very much appreciated.
I'll send out v4 in a bit.
Cheers, Martin.
On 08/10/14 14:35, Jukka Rissanen wrote:
> Hi Martin,
>
> On ke, 2014-10-08 at 13:52 +0100, Martin Townsend wrote:
>> Hi Jukka,
>>
>> I've misunderstood the constraints on pskb_expand_head. I don't suppose you could quickly try this patch it now uses skb_share_check to ensure skb->users == 1 and then I've put back in the skb_clone code that I took out which I think is causing the problem:
> Tried this one and did not see any errors so far. I will leave my test
> to run for the night. Please send a v4 and I will try to review it
> tomorrow.
>
> Cheers,
> Jukka
>
>
next prev parent reply other threads:[~2014-10-08 13:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-07 15:33 [PATCH bluetooth-next] 6lowpan: Use pskb_expand_head in IPHC decompression Martin Townsend
2014-10-07 15:33 ` Martin Townsend
2014-10-07 15:37 ` Martin Townsend
2014-10-08 10:24 ` Jukka Rissanen
2014-10-08 11:07 ` Martin Townsend
2014-10-08 12:12 ` Jukka Rissanen
2014-10-08 12:52 ` Martin Townsend
2014-10-08 13:35 ` Jukka Rissanen
2014-10-08 13:42 ` Martin Townsend [this message]
2014-10-07 16:14 ` Alexander Aring
2014-10-07 16:17 ` Alexander Aring
2014-10-07 18:25 ` Martin Townsend
2014-10-07 18:58 ` Alexander Aring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54353F58.4090301@xsilon.com \
--to=martin.townsend@xsilon.com \
--cc=alex.aring@gmail.com \
--cc=jukka.rissanen@linux.intel.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-wpan@vger.kernel.org \
--cc=marcel@holtmann.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).