From: Martin Townsend <martin.townsend@xsilon.com>
To: Alexander Aring <alex.aring@gmail.com>,
Martin Townsend <mtownsend1973@gmail.com>
Cc: linux-wpan@vger.kernel.org, linux-bluetooth@vger.kernel.org,
jukka.rissanen@linux.intel.com, marcel@holtmann.org
Subject: Re: [PATCH bluetooth-next] 6lowpan: move skb_free from error paths in decompression.
Date: Thu, 06 Nov 2014 08:11:12 +0000 [thread overview]
Message-ID: <545B2D20.2060809@xsilon.com> (raw)
In-Reply-To: <20141105210143.GA20379@omega>
Hi Alex,
It should be based on bluetooth-next. I'll check when I get home tonight.
- Martin.
On 05/11/14 21:01, Alexander Aring wrote:
> Hi Martin,
>
> On Tue, Nov 04, 2014 at 09:36:21PM +0000, Martin Townsend wrote:
>> Currently we ensure that the skb is freed on every error path in IPHC
>> decompression which makes it easy to introduce skb leaks. By centralising
>> the skb_free into the receive function it makes future decompression routines
>> easier to maintain. It does come at the expense of ensuring that the skb
>> passed into the decompression routine must not be copied.
>>
> I just want to give it a try and want to test it but I got a:
>
> error: patch failed: net/ieee802154/6lowpan_rtnl.c:200
> error: net/ieee802154/6lowpan_rtnl.c: patch does not apply ...
>
> while applying.
>
> Is the patch really based on bluetooth-next [0]? Please respin this one if
> it doesn't break anything I will ack this one.
>
> - Alex
>
> [0] http://git.kernel.org/cgit/linux/kernel/git/bluetooth/bluetooth-next.git
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wpan" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2014-11-06 8:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-04 21:36 [PATCH bluetooth-next] 6lowpan: move skb_free from error paths in decompression Martin Townsend
2014-11-05 21:01 ` Alexander Aring
2014-11-06 8:11 ` Martin Townsend [this message]
2014-11-06 10:34 ` Jukka Rissanen
2014-11-06 10:44 ` Martin Townsend
2014-11-06 10:47 ` Jukka Rissanen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=545B2D20.2060809@xsilon.com \
--to=martin.townsend@xsilon.com \
--cc=alex.aring@gmail.com \
--cc=jukka.rissanen@linux.intel.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-wpan@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=mtownsend1973@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox