From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pa0-f47.google.com ([209.85.220.47]:33889 "EHLO mail-pa0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753466AbbDIIQ2 (ORCPT ); Thu, 9 Apr 2015 04:16:28 -0400 Received: by pacyx8 with SMTP id yx8so141999160pac.1 for ; Thu, 09 Apr 2015 01:16:28 -0700 (PDT) Message-ID: <55263546.8070904@gmail.com> Date: Thu, 09 Apr 2015 13:46:06 +0530 From: Varka Bhadram MIME-Version: 1.0 Subject: Re: [PATCH bluetooth-next] mac802154: fix transmission power datatype References: <1428563696-1087-1-git-send-email-varkab@cdac.in> <0B968B37-EA54-47CE-B378-72D0B7CD8267@holtmann.org> <55262D0D.8040403@cdac.in> <1E49928F-28CB-416C-B22D-2F56CEAAAEBA@holtmann.org> In-Reply-To: <1E49928F-28CB-416C-B22D-2F56CEAAAEBA@holtmann.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-wpan-owner@vger.kernel.org List-ID: To: Marcel Holtmann , Varka Bhadram Cc: linux-wpan@vger.kernel.org, alex.aring@gmail.com On 04/09/2015 01:16 PM, Marcel Holtmann wrote: > Hi Varka, > >>>> Available 802.15.4 devices support multiple power levels, >>>> which includes positive and negative values.This patch fix >>>> set_txpower() operation arugument type to signed from int >>>> >>>> Signed-off-by: Varka Bhadram >>>> --- >>>> include/net/mac802154.h | 2 +- >>>> 1 file changed, 1 insertion(+), 1 deletion(-) >>>> >>>> diff --git a/include/net/mac802154.h b/include/net/mac802154.h >>>> index fb4e8a3d..1213419 100644 >>>> --- a/include/net/mac802154.h >>>> +++ b/include/net/mac802154.h >>>> @@ -213,7 +213,7 @@ struct ieee802154_ops { >>>> int (*set_hw_addr_filt)(struct ieee802154_hw *hw, >>>> struct ieee802154_hw_addr_filt *filt, >>>> unsigned long changed); >>>> - int (*set_txpower)(struct ieee802154_hw *hw, int db); >>>> + int (*set_txpower)(struct ieee802154_hw *hw, s8 dbm); >>> the commit message is pretty much non-sense. int is as signed as s8. >> The netlink attribute for the power level is s8. At mac level the values >> stored in s8 only [1]. > sure, but the commit message is still non-sense. Ok. I will change the commit and also i need to add the change to at86rf230 driver. -- Thanks Varka Bhadram