From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pd0-f178.google.com ([209.85.192.178]:33889 "EHLO mail-pd0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750780AbbEGMcL (ORCPT ); Thu, 7 May 2015 08:32:11 -0400 Received: by pdbqa5 with SMTP id qa5so40257567pdb.1 for ; Thu, 07 May 2015 05:32:11 -0700 (PDT) Message-ID: <554B5B31.4060503@gmail.com> Date: Thu, 07 May 2015 18:01:45 +0530 From: Varka Bhadram MIME-Version: 1.0 Subject: Re: [PATCHv2 wpan-tools] interface: use hexadecimal for print extended addr References: <1431001593-30128-1-git-send-email-alex.aring@gmail.com> In-Reply-To: <1431001593-30128-1-git-send-email-alex.aring@gmail.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-wpan-owner@vger.kernel.org List-ID: To: Alexander Aring , linux-wpan@vger.kernel.org Cc: kernel@pengutronix.de, =?UTF-8?B?R3VpZG8gR8O8bnRoZXI=?= On 05/07/2015 05:56 PM, Alexander Aring wrote: > This patch prints the extended addr in hexadecimal value. This is what > the "0x...." prefix suggested. > > Signed-off-by: Alexander Aring > Cc: Guido Günther > --- > changes since v2: > - s/inteface/interface/ > - can't remove the v we are already at v2 Nice. Reviewed-by: Varka Bhadram > src/interface.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/interface.c b/src/interface.c > index 5e0ef89..e501763 100644 > --- a/src/interface.c > +++ b/src/interface.c > @@ -203,7 +203,7 @@ static int print_iface_handler(struct nl_msg *msg, void *arg) > printf("%s\twpan_dev 0x%llx\n", indent, > (unsigned long long)nla_get_u64(tb_msg[NL802154_ATTR_WPAN_DEV])); > if (tb_msg[NL802154_ATTR_EXTENDED_ADDR]) > - printf("%s\textended_addr 0x%016" PRIu64 "\n", indent, > + printf("%s\textended_addr 0x%016" PRIx64 "\n", indent, > le64toh(nla_get_u64(tb_msg[NL802154_ATTR_EXTENDED_ADDR]))); > if (tb_msg[NL802154_ATTR_SHORT_ADDR]) > printf("%s\tshort_addr 0x%04x\n", indent, -- Varka Bhadram