From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Stefan Schmidt <stefan@osg.samsung.com>,
Alexander Aring <alex.aring@gmail.com>,
linux-wpan@vger.kernel.org
Cc: kernel@pengutronix.de
Subject: Re: [PATCH bluetooth-next 4/4] mac802154: use atomic ops for sequence incrementation
Date: Fri, 22 May 2015 12:34:19 +0200 [thread overview]
Message-ID: <555F062B.3010107@pengutronix.de> (raw)
In-Reply-To: <555F0560.8060805@osg.samsung.com>
[-- Attachment #1: Type: text/plain, Size: 999 bytes --]
On 05/22/2015 12:30 PM, Stefan Schmidt wrote:
> Hello.
>
> On 22/05/15 10:59, Marc Kleine-Budde wrote:
>> On 05/22/2015 10:57 AM, Alexander Aring wrote:
>>> This patch will use atomic operations for sequence number incrementation
>>> while MAC header generation. Upper layers like af_802154 or 6LoWPAN
>>> could call this function in a parallel context while generating 802.15.4
>>> MAC header before queuing into wpan interfaces transmit queue.
>> what about swapping patch 3 and 4?
>
> To avoid having problems during a git bisect later one? E.g. having the
> lock removed but no atomic in place?
Yes, that's what I was thinking about. I don't know the code to tell if
this is an issue here.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
next prev parent reply other threads:[~2015-05-22 10:34 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-22 8:57 [PATCH bluetooth-next 0/4] mac802154: remove pib/mib locks and locking fixes Alexander Aring
2015-05-22 8:57 ` [PATCH bluetooth-next 1/4] mac802154: fix hold rtnl while ioctl Alexander Aring
2015-05-22 12:15 ` Stefan Schmidt
2015-05-22 8:57 ` [PATCH bluetooth-next 2/4] mac802154: remove pib lock Alexander Aring
2015-05-22 12:19 ` Stefan Schmidt
2015-05-22 12:41 ` Alexander Aring
2015-05-22 12:48 ` Stefan Schmidt
2015-05-22 8:57 ` [PATCH bluetooth-next 3/4] mac802154: remove mib lock Alexander Aring
2015-05-22 12:25 ` Stefan Schmidt
2015-05-22 8:57 ` [PATCH bluetooth-next 4/4] mac802154: use atomic ops for sequence incrementation Alexander Aring
2015-05-22 8:59 ` Marc Kleine-Budde
2015-05-22 10:30 ` Stefan Schmidt
2015-05-22 10:34 ` Marc Kleine-Budde [this message]
2015-05-22 10:40 ` Stefan Schmidt
2015-05-22 12:12 ` Alexander Aring
2015-05-22 12:33 ` Stefan Schmidt
2015-05-22 12:27 ` Stefan Schmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=555F062B.3010107@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=alex.aring@gmail.com \
--cc=kernel@pengutronix.de \
--cc=linux-wpan@vger.kernel.org \
--cc=stefan@osg.samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox