Linux IEEE 802.15.4 and 6LoWPAN development
 help / color / mirror / Atom feed
From: Varka Bhadram <varkabhadram@gmail.com>
To: linux-wpan@vger.kernel.org
Cc: Varka Bhadram <varkab@cdac.in>
Subject: Re: [PATCH bluetooth-next 2/3] cc2520: update initial transmit power value
Date: Thu, 28 May 2015 12:57:54 +0530	[thread overview]
Message-ID: <5566C37A.6060508@gmail.com> (raw)
In-Reply-To: <1432795860-16462-2-git-send-email-varkab@cdac.in>

On 05/28/2015 12:20 PM, Varka Bhadram wrote:

> CC2520 has the default 0dBm transmit power level  on reset.
> This patch update initial value of transmit power with 0dBm value.

CC2520 has the 0dBm value on reset, but in the driver we are setting
tx power value to 5dBm.

> Signed-off-by: Varka Bhadram <varkab@cdac.in>
> ---
>   drivers/net/ieee802154/cc2520.c |    2 ++
>   1 file changed, 2 insertions(+)
>
> diff --git a/drivers/net/ieee802154/cc2520.c b/drivers/net/ieee802154/cc2520.c
> index a20e6d4..94347d4 100644
> --- a/drivers/net/ieee802154/cc2520.c
> +++ b/drivers/net/ieee802154/cc2520.c
> @@ -708,6 +708,8 @@ static int cc2520_register(struct cc2520_private *priv)
>   	priv->hw->phy->supported.tx_powers = cc2520_powers;
>   	priv->hw->phy->supported.tx_powers_size = ARRAY_SIZE(cc2520_powers);
>   
> +	priv->hw->phy->transmit_power = priv->hw->phy->supported.tx_powers[4];
> +

This has to be:

priv->hw->phy->transmit_power = priv->hw->phy->supported.tx_powers[0];

>   	dev_vdbg(&priv->spi->dev, "registered cc2520\n");
>   	ret = ieee802154_register_hw(priv->hw);
>   	if (ret)

-- 
Varka Bhadram


  reply	other threads:[~2015-05-28  7:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-05-28  6:50 [PATCH bluetooth-next 1/3] cc2520: add set transmit power setting support Varka Bhadram
2015-05-28  6:50 ` [PATCH bluetooth-next 2/3] cc2520: update initial transmit power value Varka Bhadram
2015-05-28  7:27   ` Varka Bhadram [this message]
2015-05-28  8:17     ` Stefan Schmidt
2015-05-28  8:38       ` Varka Bhadram
2015-05-28  6:51 ` [PATCH bluetooth-next 3/3] cc2520: update current channel Varka Bhadram

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5566C37A.6060508@gmail.com \
    --to=varkabhadram@gmail.com \
    --cc=linux-wpan@vger.kernel.org \
    --cc=varkab@cdac.in \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox