linux-wpan.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Schmidt <stefan@osg.samsung.com>
To: Alexander Aring <alex.aring@gmail.com>, linux-wpan@vger.kernel.org
Cc: kernel@pengutronix.de, alan@signal11.us, jonatan@myeden.se
Subject: Re: [RFC bluetooth-next 01/21] mrf24j40: cleanup define identation
Date: Thu, 27 Aug 2015 14:59:38 +0200	[thread overview]
Message-ID: <55DF09BA.2020303@osg.samsung.com> (raw)
In-Reply-To: <1439468568-22288-2-git-send-email-alex.aring@gmail.com>

Hello.

On 13/08/15 14:22, Alexander Aring wrote:
> This patch replaces the spaces after define by a tab.
>
> Signed-off-by: Alexander Aring <alex.aring@gmail.com>
> ---
>   drivers/net/ieee802154/mrf24j40.c | 76 +++++++++++++++++++--------------------
>   1 file changed, 38 insertions(+), 38 deletions(-)
>
> diff --git a/drivers/net/ieee802154/mrf24j40.c b/drivers/net/ieee802154/mrf24j40.c
> index 997724b..2b7fc00 100644
> --- a/drivers/net/ieee802154/mrf24j40.c
> +++ b/drivers/net/ieee802154/mrf24j40.c
> @@ -23,46 +23,46 @@
>   #include <net/mac802154.h>
>   
>   /* MRF24J40 Short Address Registers */
> -#define REG_RXMCR    0x00  /* Receive MAC control */
> -#define REG_PANIDL   0x01  /* PAN ID (low) */
> -#define REG_PANIDH   0x02  /* PAN ID (high) */
> -#define REG_SADRL    0x03  /* Short address (low) */
> -#define REG_SADRH    0x04  /* Short address (high) */
> -#define REG_EADR0    0x05  /* Long address (low) (high is EADR7) */
> -#define REG_TXMCR    0x11  /* Transmit MAC control */
> -#define REG_PACON0   0x16  /* Power Amplifier Control */
> -#define REG_PACON1   0x17  /* Power Amplifier Control */
> -#define REG_PACON2   0x18  /* Power Amplifier Control */
> -#define REG_TXNCON   0x1B  /* Transmit Normal FIFO Control */
> -#define REG_TXSTAT   0x24  /* TX MAC Status Register */
> -#define REG_SOFTRST  0x2A  /* Soft Reset */
> -#define REG_TXSTBL   0x2E  /* TX Stabilization */
> -#define REG_INTSTAT  0x31  /* Interrupt Status */
> -#define REG_INTCON   0x32  /* Interrupt Control */
> -#define REG_GPIO     0x33  /* GPIO */
> -#define REG_TRISGPIO 0x34  /* GPIO direction */
> -#define REG_RFCTL    0x36  /* RF Control Mode Register */
> -#define REG_BBREG1   0x39  /* Baseband Registers */
> -#define REG_BBREG2   0x3A  /* */
> -#define REG_BBREG6   0x3E  /* */
> -#define REG_CCAEDTH  0x3F  /* Energy Detection Threshold */
> +#define REG_RXMCR	0x00  /* Receive MAC control */
> +#define REG_PANIDL	0x01  /* PAN ID (low) */
> +#define REG_PANIDH	0x02  /* PAN ID (high) */
> +#define REG_SADRL	0x03  /* Short address (low) */
> +#define REG_SADRH	0x04  /* Short address (high) */
> +#define REG_EADR0	0x05  /* Long address (low) (high is EADR7) */
> +#define REG_TXMCR	0x11  /* Transmit MAC control */
> +#define REG_PACON0	0x16  /* Power Amplifier Control */
> +#define REG_PACON1	0x17  /* Power Amplifier Control */
> +#define REG_PACON2	0x18  /* Power Amplifier Control */
> +#define REG_TXNCON	0x1B  /* Transmit Normal FIFO Control */
> +#define REG_TXSTAT	0x24  /* TX MAC Status Register */
> +#define REG_SOFTRST	0x2A  /* Soft Reset */
> +#define REG_TXSTBL	0x2E  /* TX Stabilization */
> +#define REG_INTSTAT	0x31  /* Interrupt Status */
> +#define REG_INTCON	0x32  /* Interrupt Control */
> +#define REG_GPIO	0x33  /* GPIO */
> +#define REG_TRISGPIO	0x34  /* GPIO direction */
> +#define REG_RFCTL	0x36  /* RF Control Mode Register */
> +#define REG_BBREG1	0x39  /* Baseband Registers */
> +#define REG_BBREG2	0x3A  /* */
> +#define REG_BBREG6	0x3E  /* */
> +#define REG_CCAEDTH	0x3F  /* Energy Detection Threshold */
>   
>   /* MRF24J40 Long Address Registers */
> -#define REG_RFCON0     0x200  /* RF Control Registers */
> -#define REG_RFCON1     0x201
> -#define REG_RFCON2     0x202
> -#define REG_RFCON3     0x203
> -#define REG_RFCON5     0x205
> -#define REG_RFCON6     0x206
> -#define REG_RFCON7     0x207
> -#define REG_RFCON8     0x208
> -#define REG_RSSI       0x210
> -#define REG_SLPCON0    0x211  /* Sleep Clock Control Registers */
> -#define REG_SLPCON1    0x220
> -#define REG_WAKETIMEL  0x222  /* Wake-up Time Match Value Low */
> -#define REG_WAKETIMEH  0x223  /* Wake-up Time Match Value High */
> -#define REG_TESTMODE   0x22F  /* Test mode */
> -#define REG_RX_FIFO    0x300  /* Receive FIFO */
> +#define REG_RFCON0	0x200  /* RF Control Registers */
> +#define REG_RFCON1	0x201
> +#define REG_RFCON2	0x202
> +#define REG_RFCON3	0x203
> +#define REG_RFCON5	0x205
> +#define REG_RFCON6	0x206
> +#define REG_RFCON7	0x207
> +#define REG_RFCON8	0x208
> +#define REG_RSSI	0x210
> +#define REG_SLPCON0	0x211  /* Sleep Clock Control Registers */
> +#define REG_SLPCON1	0x220
> +#define REG_WAKETIMEL	0x222  /* Wake-up Time Match Value Low */
> +#define REG_WAKETIMEH	0x223  /* Wake-up Time Match Value High */
> +#define REG_TESTMODE	0x22F  /* Test mode */
> +#define REG_RX_FIFO	0x300  /* Receive FIFO */
>   
>   /* Device configuration: Only channels 11-26 on page 0 are supported. */
>   #define MRF24J40_CHAN_MIN 11

Reviewed-by: Stefan Schmidt <stefan@osg.samsung.com>

regards
Stefan Schmidt

  reply	other threads:[~2015-08-27 12:59 UTC|newest]

Thread overview: 51+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-13 12:22 [RFC bluetooth-next 00/21] mrf24j40: async rx/tx handling and new features Alexander Aring
2015-08-13 12:22 ` [RFC bluetooth-next 01/21] mrf24j40: cleanup define identation Alexander Aring
2015-08-27 12:59   ` Stefan Schmidt [this message]
2015-08-13 12:22 ` [RFC bluetooth-next 02/21] mrf24j40: use ieee802154_alloc_hw for private data Alexander Aring
2015-08-27 13:03   ` Stefan Schmidt
2015-08-13 12:22 ` [RFC bluetooth-next 03/21] mrf24j40: calling ieee802154_register_hw at last Alexander Aring
2015-08-27 13:06   ` Stefan Schmidt
2015-08-13 12:22 ` [RFC bluetooth-next 04/21] mrf24j40: remove spi settings overwrite Alexander Aring
2015-08-27 13:14   ` Stefan Schmidt
2015-08-28  7:50     ` Alexander Aring
2015-08-28  7:58       ` Stefan Schmidt
2015-08-13 12:22 ` [RFC bluetooth-next 05/21] mrf24j40: add device-tree support Alexander Aring
2015-08-27 13:16   ` Stefan Schmidt
2015-08-13 12:22 ` [RFC bluetooth-next 06/21] mrf24j40: add default channel setting Alexander Aring
2015-08-27 13:24   ` Stefan Schmidt
2015-08-13 12:22 ` [RFC bluetooth-next 07/21] mrf24j40: add random extended addr generation Alexander Aring
2015-08-27 13:25   ` Stefan Schmidt
2015-08-13 12:22 ` [RFC bluetooth-next 08/21] mrf24j40: add more register defines Alexander Aring
2015-08-27 13:28   ` Stefan Schmidt
2015-08-13 12:22 ` [RFC bluetooth-next 09/21] mrf24j40: add regmap support Alexander Aring
2015-08-27 17:45   ` Alexander Aring
2015-08-28  8:37   ` Stefan Schmidt
2015-08-13 12:22 ` [RFC bluetooth-next 10/21] mrf24j40: use regmap for register access Alexander Aring
2015-08-28  8:43   ` Stefan Schmidt
2015-08-13 12:22 ` [RFC bluetooth-next 11/21] mrf24j40: change to frame delivery with crc Alexander Aring
2015-08-27 13:30   ` Stefan Schmidt
2015-08-13 12:22 ` [RFC bluetooth-next 12/21] ieee802154: add helpers for frame control checks Alexander Aring
2015-08-13 12:22 ` [RFC bluetooth-next 13/21] mrf24j40: rework tx handling to async tx handling Alexander Aring
2015-08-28  8:50   ` Stefan Schmidt
2015-08-13 12:22 ` [RFC bluetooth-next 14/21] mrf24j40: rework rx handling to async rx handling Alexander Aring
2015-08-28  8:55   ` Stefan Schmidt
2015-08-13 12:22 ` [RFC bluetooth-next 15/21] mrf24j40: async interrupt handling Alexander Aring
2015-08-28  8:57   ` Stefan Schmidt
2015-08-13 12:22 ` [RFC bluetooth-next 16/21] mrf24j40: add csma params support Alexander Aring
2015-08-27 13:46   ` Stefan Schmidt
2015-08-28  7:53     ` Alexander Aring
2015-08-13 12:22 ` [RFC bluetooth-next 17/21] mrf24j40: add cca mode support Alexander Aring
2015-08-27 13:50   ` Stefan Schmidt
2015-08-27 17:49   ` Alexander Aring
2015-08-13 12:22 ` [RFC bluetooth-next 18/21] mrf24j40: add cca ed level support Alexander Aring
2015-08-27 13:52   ` Stefan Schmidt
2015-08-27 17:44   ` Alexander Aring
2015-08-13 12:22 ` [RFC bluetooth-next 19/21] mrf24j40: add tx power support Alexander Aring
2015-08-27 13:59   ` Stefan Schmidt
2015-08-13 12:22 ` [RFC bluetooth-next 20/21] mrf24j40: add promiscuous mode support Alexander Aring
2015-08-27 14:00   ` Stefan Schmidt
2015-08-13 12:22 ` [RFC bluetooth-next 21/21] mrf24j40: change irq trigger type behaviour Alexander Aring
2015-08-28  8:28   ` Stefan Schmidt
2015-08-18 13:54 ` [RFC bluetooth-next 00/21] mrf24j40: async rx/tx handling and new features Alan Ott
2015-08-27 12:29 ` Stefan Schmidt
2015-08-27 12:33   ` Alan Ott

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=55DF09BA.2020303@osg.samsung.com \
    --to=stefan@osg.samsung.com \
    --cc=alan@signal11.us \
    --cc=alex.aring@gmail.com \
    --cc=jonatan@myeden.se \
    --cc=kernel@pengutronix.de \
    --cc=linux-wpan@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).