From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from lists.s-osg.org ([54.187.51.154]:60403 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751930AbbH0NQp (ORCPT ); Thu, 27 Aug 2015 09:16:45 -0400 Subject: Re: [RFC bluetooth-next 05/21] mrf24j40: add device-tree support References: <1439468568-22288-1-git-send-email-alex.aring@gmail.com> <1439468568-22288-6-git-send-email-alex.aring@gmail.com> From: Stefan Schmidt Message-ID: <55DF0DB9.6050109@osg.samsung.com> Date: Thu, 27 Aug 2015 15:16:41 +0200 MIME-Version: 1.0 In-Reply-To: <1439468568-22288-6-git-send-email-alex.aring@gmail.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-wpan-owner@vger.kernel.org List-ID: To: Alexander Aring , linux-wpan@vger.kernel.org Cc: kernel@pengutronix.de, alan@signal11.us, jonatan@myeden.se Hello. On 13/08/15 14:22, Alexander Aring wrote: > This patch adds devicetree support to mrf24j40 with proper devicetree > compatible strings. > > Signed-off-by: Alexander Aring > --- > .../devicetree/bindings/net/ieee802154/mrf24j40.txt | 20 ++++++++++++++++++++ > MAINTAINERS | 1 + > drivers/net/ieee802154/mrf24j40.c | 9 +++++++++ > 3 files changed, 30 insertions(+) > create mode 100644 Documentation/devicetree/bindings/net/ieee802154/mrf24j40.txt > > diff --git a/Documentation/devicetree/bindings/net/ieee802154/mrf24j40.txt b/Documentation/devicetree/bindings/net/ieee802154/mrf24j40.txt > new file mode 100644 > index 0000000..a4ed2ef > --- /dev/null > +++ b/Documentation/devicetree/bindings/net/ieee802154/mrf24j40.txt > @@ -0,0 +1,20 @@ > +* MRF24J40 IEEE 802.15.4 * > + > +Required properties: > + - compatible: should be "microchip,mrf24j40", "microchip,mrf24j40ma", > + or "microchip,mrf24j40mc" depends on your transceiver > + board > + - spi-max-frequency: maximal bus speed, should be set something under or equal > + 10000000 > + - reg: the chipselect index > + - interrupts: the interrupt generated by the device. > + > +Example: > + > + mrf24j40ma@0 { > + compatible = "microchip,mrf24j40ma"; > + spi-max-frequency = <8500000>; > + reg = <0>; > + interrupts = <19 8>; > + interrupt-parent = <&gpio3>; > + }; > diff --git a/MAINTAINERS b/MAINTAINERS > index 5baa91c..0af4165 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -6816,6 +6816,7 @@ M: Alan Ott > L: linux-wpan@vger.kernel.org > S: Maintained > F: drivers/net/ieee802154/mrf24j40.c > +F: Documentation/devicetree/bindings/net/ieee802154/mrf24j40.txt > > MSI LAPTOP SUPPORT > M: "Lee, Chun-Yi" > diff --git a/drivers/net/ieee802154/mrf24j40.c b/drivers/net/ieee802154/mrf24j40.c > index d16bef3..7df80d8 100644 > --- a/drivers/net/ieee802154/mrf24j40.c > +++ b/drivers/net/ieee802154/mrf24j40.c > @@ -793,6 +793,14 @@ static int mrf24j40_remove(struct spi_device *spi) > return 0; > } > > +static const struct of_device_id mrf24j40_of_match[] = { > + { .compatible = "microchip,mrf24j40", .data = (void *)MRF24J40 }, > + { .compatible = "microchip,mrf24j40ma", .data = (void *)MRF24J40MA }, > + { .compatible = "microchip,mrf24j40mc", .data = (void *)MRF24J40MC }, > + { }, > +}; > +MODULE_DEVICE_TABLE(of, mrf24j40_of_match); > + > static const struct spi_device_id mrf24j40_ids[] = { > { "mrf24j40", MRF24J40 }, > { "mrf24j40ma", MRF24J40MA }, > @@ -803,6 +811,7 @@ MODULE_DEVICE_TABLE(spi, mrf24j40_ids); > > static struct spi_driver mrf24j40_driver = { > .driver = { > + .of_match_table = of_match_ptr(mrf24j40_of_match), > .name = "mrf24j40", > .owner = THIS_MODULE, > }, Reviewed-by: Stefan Schmidt regards Stefan Schmidt