Re: [RFC bluetooth-next 11/21] mrf24j40: change to frame delivery with crc

[Stefan Schmidt <stefan@osg.samsung.com>]

Hello.

On 13/08/15 14:22, Alexander Aring wrote:
> This patch changes the frame delivery to mac802154 with crc. This is
> useful for monitor interface types which deliver the crc to userspace.
>
> Signed-off-by: Alexander Aring <alex.aring@gmail.com>
> ---
>   drivers/net/ieee802154/mrf24j40.c | 5 +----
>   1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/net/ieee802154/mrf24j40.c b/drivers/net/ieee802154/mrf24j40.c
> index 32de5d6..7e6a038 100644
> --- a/drivers/net/ieee802154/mrf24j40.c
> +++ b/drivers/net/ieee802154/mrf24j40.c
> @@ -881,9 +881,6 @@ static int mrf24j40_handle_rx(struct mrf24j40 *devrec)
>   		goto out;
>   	}
>   
> -	/* Cut off the checksum */
> -	skb_trim(skb, len-2);
> -
>   	/* TODO: Other drivers call ieee20154_rx_irqsafe() here (eg: cc2040,
>   	 * also from a workqueue).  I think irqsafe is not necessary here.
>   	 * Can someone confirm? */
> @@ -1060,7 +1057,7 @@ static int mrf24j40_probe(struct spi_device *spi)
>   	devrec->hw = hw;
>   	devrec->hw->parent = &spi->dev;
>   	devrec->hw->phy->supported.channels[0] = CHANNEL_MASK;
> -	devrec->hw->flags = IEEE802154_HW_OMIT_CKSUM | IEEE802154_HW_AFILT;
> +	devrec->hw->flags = IEEE802154_HW_TX_OMIT_CKSUM | IEEE802154_HW_AFILT;
>   
>   	devrec->regmap_short = devm_regmap_init_spi(spi,
>   						    &mrf24j40_short_regmap);

Good change. Let the stack handle this part and decide on what the user 
wants (monitor mode or normal)

Reviewed-by: Stefan Schmidt <stefan@osg.samsung.com>

regards
Stefan Schmidt