From: Stefan Schmidt <stefan@osg.samsung.com>
To: Alexander Aring <alex.aring@gmail.com>
Cc: linux-wpan@vger.kernel.org
Subject: Re: [PATCH wpan-tools] build: avoid redefinition errors with libnl >= 3.2.27
Date: Mon, 9 Nov 2015 22:11:43 +0100 [thread overview]
Message-ID: <56410C0F.7030300@osg.samsung.com> (raw)
In-Reply-To: <20151109201821.GA608@omega>
Hello.
On 09/11/15 21:19, Alexander Aring wrote:
> Hi,
>
> On Mon, Nov 09, 2015 at 07:10:42PM +0100, Stefan Schmidt wrote:
>> From 3.2.17 onwards we have nla for s8, s16, etc defined directly in libnl.
>> If we keep including this file anyway we run into redefinition errors. Better
>> include use our own only for earlier versions.
>>
>> Happened to me on Fedora 22 after my last update.
>>
>> Signed-off-by: Stefan Schmidt <stefan@osg.samsung.com>
> Acked-by: Alexander Aring <alex.aring@gmail.com>
Thanks. Pushed.
> I wonder how could that be when I do #ifndef on each declaration. So I
> was in the hope to avoid such issues....
>
Longer term we should just bump our dependency to 3.2.27 and remove our
own defines here. I just avoided that for now as the release is to new
and we should wait for distros to adopt it first. Maybe in 6 months from
now we can do that.
regards
Stefan Schmidt
prev parent reply other threads:[~2015-11-09 21:11 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-09 18:10 [PATCH wpan-tools] build: avoid redefinition errors with libnl >= 3.2.27 Stefan Schmidt
2015-11-09 20:19 ` Alexander Aring
2015-11-09 21:11 ` Stefan Schmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56410C0F.7030300@osg.samsung.com \
--to=stefan@osg.samsung.com \
--cc=alex.aring@gmail.com \
--cc=linux-wpan@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).