From: Varka Bhadram <varkabhadram@gmail.com>
To: Brad Campbell <bradjc5@gmail.com>,
Alexander Aring <alex.aring@gmail.com>,
linux-wpan@vger.kernel.org
Subject: Re: [PATCH v3 1/1] ieee802154: cc2520: Check CRC & add promiscuous
Date: Thu, 31 Dec 2015 20:37:35 +0530 [thread overview]
Message-ID: <568544B7.3010903@gmail.com> (raw)
In-Reply-To: <1450923581-967-2-git-send-email-bradjc5@gmail.com>
Hi Brad Campbell,
On 12/24/2015 7:49 AM, Brad Campbell wrote:
> This patch adds checking the "CRC_OK" bit at the end of packets coming
> from the CC2520 radio. It also adds support for putting the radio in
> promiscuous mode (in which packets are not dropped if the CRC fails).
> In promiscuous mode the AUTOCRC flag is cleared so that the driver can
> pass the received CRC to the monitors.
>
> The radio now defaults to frame filtering (checking that the destination
> and PANID in the incoming packet matches the local node). This matches
> the other 15.4 radios and is what a user would expect to be the default.
>
> Other changes:
>
> 1. Adds LQI calculation
> 2. Makes #defines for relevant bit fields in CC2520 registers
>
> Signed-off-by: Brad Campbell <bradjc5@gmail.com>
> ---
> drivers/net/ieee802154/cc2520.c | 145 +++++++++++++++++++++++++++++++++-------
> 1 file changed, 122 insertions(+), 23 deletions(-)
>
Looks good to me.
Acked-by: Varka Bhadram <varkabhadram@gmail.com>
next prev parent reply other threads:[~2015-12-31 15:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-24 2:19 [PATCH v3 0/1] ieee802154: cc2520: Check CRC & add promiscuous Brad Campbell
2015-12-24 2:19 ` [PATCH v3 1/1] " Brad Campbell
2015-12-31 15:07 ` Varka Bhadram [this message]
2015-12-31 19:06 ` [PATCH v3 0/1] " Marcel Holtmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=568544B7.3010903@gmail.com \
--to=varkabhadram@gmail.com \
--cc=alex.aring@gmail.com \
--cc=bradjc5@gmail.com \
--cc=linux-wpan@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox