Re: [PATCH 2/4] wan/hdlc_x25: fix skb handling

David Miller
2019-04-05T00:32:40Z

From: Martin Schiller <ms@dev.tdt.de>
Date: Wed, 3 Apr 2019 07:01:16 +0200

> /* X.25 to LAPB */
> switch (skb->data[0]) {
> case X25_IFACE_DATA: /* Data to be transmitted */
> - skb_pull(skb, 1);
> - if ((result = lapb_data_request(dev, skb)) != LAPB_OK)
> - dev_kfree_skb(skb);
> - return NETDEV_TX_OK;
> + skbn = skb_copy(skb, GFP_ATOMIC);
> + skb_pull(skbn, 1);
> + skb_reset_network_header(skbn);
> + if ((result = lapb_data_request(dev, skbn)) != LAPB_OK)
> + dev_kfree_skb(skbn);

This leaks 'skb'.

No way I'm applying this stuff.