From: David Miller <davem@davemloft.net>
To: xie.he.0141@gmail.com
Cc: kuba@kernel.org, linux-x25@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
ms@dev.tdt.de
Subject: Re: [PATCH net-next] net: x25: Fix handling of Restart Request and Restart Confirmation
Date: Wed, 09 Dec 2020 19:35:06 -0800 (PST) [thread overview]
Message-ID: <20201209.193506.2090158352867619865.davem@davemloft.net> (raw)
In-Reply-To: <20201209081604.464084-1-xie.he.0141@gmail.com>
From: Xie He <xie.he.0141@gmail.com>
Date: Wed, 9 Dec 2020 00:16:04 -0800
> 1. When the x25 module gets loaded, layer 2 may already be running and
> connected. In this case, although we are in X25_LINK_STATE_0, we still
> need to handle the Restart Request received, rather than ignore it.
>
> 2. When we are in X25_LINK_STATE_2, we have already sent a Restart Request
> and is waiting for the Restart Confirmation with t20timer. t20timer will
> restart itself repeatedly forever so it will always be there, as long as we
> are in State 2. So we don't need to check x25_t20timer_pending again.
>
> Fixes: d023b2b9ccc2 ("net/x25: fix restart request/confirm handling")
> Cc: Martin Schiller <ms@dev.tdt.de>
> Signed-off-by: Xie He <xie.he.0141@gmail.com>
Applied, thanks.
prev parent reply other threads:[~2020-12-10 3:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-09 8:16 [PATCH net-next] net: x25: Fix handling of Restart Request and Restart Confirmation Xie He
2020-12-09 9:52 ` Martin Schiller
2020-12-09 10:31 ` Martin Schiller
2020-12-09 20:16 ` Xie He
2020-12-10 6:35 ` Martin Schiller
2020-12-10 9:40 ` Xie He
2020-12-10 3:35 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201209.193506.2090158352867619865.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-x25@vger.kernel.org \
--cc=ms@dev.tdt.de \
--cc=netdev@vger.kernel.org \
--cc=xie.he.0141@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox