From: Martin Schiller <ms@dev.tdt.de>
To: "Jεan Sacren" <sakiwit@gmail.com>
Cc: davem@davemloft.net, kuba@kernel.org, linux-x25@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next] net: x25: drop harmless check of !more
Date: Wed, 08 Dec 2021 08:51:17 +0100 [thread overview]
Message-ID: <591bfc0470ca596995e13337460f99d0@dev.tdt.de> (raw)
In-Reply-To: <20211208024732.142541-5-sakiwit@gmail.com>
On 2021-12-08 08:20, Jεan Sacren wrote:
> From: Jean Sacren <sakiwit@gmail.com>
>
> 'more' is checked first. When !more is checked immediately after that,
> it is always true. We should drop this check.
>
> Signed-off-by: Jean Sacren <sakiwit@gmail.com>
> ---
> net/x25/x25_in.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/x25/x25_in.c b/net/x25/x25_in.c
> index e1c4197af468..b981a4828d08 100644
> --- a/net/x25/x25_in.c
> +++ b/net/x25/x25_in.c
> @@ -41,7 +41,7 @@ static int x25_queue_rx_frame(struct sock *sk,
> struct sk_buff *skb, int more)
> return 0;
> }
>
> - if (!more && x25->fraglen > 0) { /* End of fragment */
> + if (x25->fraglen > 0) { /* End of fragment */
> int len = x25->fraglen + skb->len;
>
> if ((skbn = alloc_skb(len, GFP_ATOMIC)) == NULL){
Acked-by: Martin Schiller <ms@dev.tdt.de>
next prev parent reply other threads:[~2021-12-08 7:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-08 7:20 [PATCH net-next] net: x25: drop harmless check of !more Jεan Sacren
2021-12-08 7:51 ` Martin Schiller [this message]
2021-12-10 3:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=591bfc0470ca596995e13337460f99d0@dev.tdt.de \
--to=ms@dev.tdt.de \
--cc=davem@davemloft.net \
--cc=kuba@kernel.org \
--cc=linux-x25@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sakiwit@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).