* [PATCH] misc: remove COPYING from doc/ Makefile
@ 2018-07-31 3:41 Eric Sandeen
2018-07-31 3:45 ` Darrick J. Wong
2018-07-31 7:43 ` Christoph Hellwig
0 siblings, 2 replies; 6+ messages in thread
From: Eric Sandeen @ 2018-07-31 3:41 UTC (permalink / raw)
To: linux-xfs
COPYING is gone now, so make doc-install breaks.
Fixes: 959ef98 ("xfsprogs: convert to SPDX license tags")
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
diff --git a/doc/Makefile b/doc/Makefile
index 8b870dc..83dfa38 100644
--- a/doc/Makefile
+++ b/doc/Makefile
@@ -5,7 +5,7 @@
TOPDIR = ..
include $(TOPDIR)/include/builddefs
-LSRCFILES = INSTALL CHANGES COPYING CREDITS sparse.txt
+LSRCFILES = INSTALL CHANGES CREDITS sparse.txt
LDIRT = *.gz
default: CHANGES.gz
@@ -21,8 +21,6 @@ install: default
$(INSTALL) -m 644 CHANGES.gz CREDITS $(PKG_DOC_DIR)
ifeq ($(PKG_DISTRIBUTION), debian)
$(INSTALL) -S CHANGES.gz $(PKG_DOC_DIR)/changelog.gz
-else
- $(INSTALL) -m 644 COPYING $(PKG_DOC_DIR)
endif
install-dev:
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] misc: remove COPYING from doc/ Makefile
2018-07-31 3:41 [PATCH] misc: remove COPYING from doc/ Makefile Eric Sandeen
@ 2018-07-31 3:45 ` Darrick J. Wong
2018-07-31 7:43 ` Christoph Hellwig
1 sibling, 0 replies; 6+ messages in thread
From: Darrick J. Wong @ 2018-07-31 3:45 UTC (permalink / raw)
To: Eric Sandeen; +Cc: linux-xfs
On Mon, Jul 30, 2018 at 10:41:54PM -0500, Eric Sandeen wrote:
> COPYING is gone now, so make doc-install breaks.
>
> Fixes: 959ef98 ("xfsprogs: convert to SPDX license tags")
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Looks ok,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>
--D
> ---
>
> diff --git a/doc/Makefile b/doc/Makefile
> index 8b870dc..83dfa38 100644
> --- a/doc/Makefile
> +++ b/doc/Makefile
> @@ -5,7 +5,7 @@
> TOPDIR = ..
> include $(TOPDIR)/include/builddefs
>
> -LSRCFILES = INSTALL CHANGES COPYING CREDITS sparse.txt
> +LSRCFILES = INSTALL CHANGES CREDITS sparse.txt
> LDIRT = *.gz
>
> default: CHANGES.gz
> @@ -21,8 +21,6 @@ install: default
> $(INSTALL) -m 644 CHANGES.gz CREDITS $(PKG_DOC_DIR)
> ifeq ($(PKG_DISTRIBUTION), debian)
> $(INSTALL) -S CHANGES.gz $(PKG_DOC_DIR)/changelog.gz
> -else
> - $(INSTALL) -m 644 COPYING $(PKG_DOC_DIR)
> endif
>
> install-dev:
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] misc: remove COPYING from doc/ Makefile
2018-07-31 3:41 [PATCH] misc: remove COPYING from doc/ Makefile Eric Sandeen
2018-07-31 3:45 ` Darrick J. Wong
@ 2018-07-31 7:43 ` Christoph Hellwig
2018-07-31 8:06 ` Dave Chinner
1 sibling, 1 reply; 6+ messages in thread
From: Christoph Hellwig @ 2018-07-31 7:43 UTC (permalink / raw)
To: Eric Sandeen; +Cc: linux-xfs
On Mon, Jul 30, 2018 at 10:41:54PM -0500, Eric Sandeen wrote:
> COPYING is gone now, so make doc-install breaks.
>
> Fixes: 959ef98 ("xfsprogs: convert to SPDX license tags")
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
The patch itself looks good, but I think we have a deeper problem,
in that there is no actual license information anywhere in xfsprogs now.
We need to fix that up similar to the LICENSES/ directory in the kernel.
SPDX tags are good and nice, but without an explanation what they mean
in the same source tree they are useless.
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] misc: remove COPYING from doc/ Makefile
2018-07-31 7:43 ` Christoph Hellwig
@ 2018-07-31 8:06 ` Dave Chinner
2018-07-31 8:08 ` Christoph Hellwig
0 siblings, 1 reply; 6+ messages in thread
From: Dave Chinner @ 2018-07-31 8:06 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: Eric Sandeen, linux-xfs
On Tue, Jul 31, 2018 at 12:43:13AM -0700, Christoph Hellwig wrote:
> On Mon, Jul 30, 2018 at 10:41:54PM -0500, Eric Sandeen wrote:
> > COPYING is gone now, so make doc-install breaks.
> >
> > Fixes: 959ef98 ("xfsprogs: convert to SPDX license tags")
> >
> > Signed-off-by: Eric Sandeen <sandeen@redhat.com>
>
> The patch itself looks good, but I think we have a deeper problem,
> in that there is no actual license information anywhere in xfsprogs now.
>
> We need to fix that up similar to the LICENSES/ directory in the kernel.
> SPDX tags are good and nice, but without an explanation what they mean
> in the same source tree they are useless.
Sorry, what? I added that as part of my spdx conversion patch. That
patch also removed the COPYING file.
How did these changes get merged? I sent a pull request to convert
everything in xfsprogs and that had all the correct conversions and
documentation in it. here's the pull request:
https://marc.info/?l=linux-xfs&m=152948738523911&w=2
and you can see from the diffstat it did all this stuff...
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] misc: remove COPYING from doc/ Makefile
2018-07-31 8:06 ` Dave Chinner
@ 2018-07-31 8:08 ` Christoph Hellwig
2018-07-31 15:36 ` Eric Sandeen
0 siblings, 1 reply; 6+ messages in thread
From: Christoph Hellwig @ 2018-07-31 8:08 UTC (permalink / raw)
To: Dave Chinner; +Cc: Christoph Hellwig, Eric Sandeen, linux-xfs
On Tue, Jul 31, 2018 at 06:06:46PM +1000, Dave Chinner wrote:
> Sorry, what? I added that as part of my spdx conversion patch. That
> patch also removed the COPYING file.
>
> How did these changes get merged? I sent a pull request to convert
> everything in xfsprogs and that had all the correct conversions and
> documentation in it. here's the pull request:
>
> https://marc.info/?l=linux-xfs&m=152948738523911&w=2
>
> and you can see from the diffstat it did all this stuff...
Ok. I looked for license info in master but that didn't have the
whole conversion. That master vs for-next think in the userspace
tools keeps on confusing me..
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] misc: remove COPYING from doc/ Makefile
2018-07-31 8:08 ` Christoph Hellwig
@ 2018-07-31 15:36 ` Eric Sandeen
0 siblings, 0 replies; 6+ messages in thread
From: Eric Sandeen @ 2018-07-31 15:36 UTC (permalink / raw)
To: Christoph Hellwig, Dave Chinner; +Cc: linux-xfs
On 7/31/18 3:08 AM, Christoph Hellwig wrote:
> On Tue, Jul 31, 2018 at 06:06:46PM +1000, Dave Chinner wrote:
>> Sorry, what? I added that as part of my spdx conversion patch. That
>> patch also removed the COPYING file.
>>
>> How did these changes get merged? I sent a pull request to convert
>> everything in xfsprogs and that had all the correct conversions and
>> documentation in it. here's the pull request:
>>
>> https://marc.info/?l=linux-xfs&m=152948738523911&w=2
>>
>> and you can see from the diffstat it did all this stuff...
>
> Ok. I looked for license info in master but that didn't have the
> whole conversion. That master vs for-next think in the userspace
> tools keeps on confusing me..
>
Sorry about that.
I can rethink it if needed, when I started this gig I was keeping
everything in rebaseable for-next because I feared egregious mistakes.
That's still possible but I'd like to think I'm a little better at it now ;)
-Eric
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-07-31 17:16 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-07-31 3:41 [PATCH] misc: remove COPYING from doc/ Makefile Eric Sandeen
2018-07-31 3:45 ` Darrick J. Wong
2018-07-31 7:43 ` Christoph Hellwig
2018-07-31 8:06 ` Dave Chinner
2018-07-31 8:08 ` Christoph Hellwig
2018-07-31 15:36 ` Eric Sandeen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).