From: Nikolay Borisov <nborisov@suse.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: linux-xfs@vger.kernel.org, sandeen@redhat.com, darrick.wong@oracle.com
Subject: Re: [PATCH] xfs: Don't trim extents for fiemap
Date: Thu, 23 Nov 2017 13:35:22 +0200 [thread overview]
Message-ID: <01f6e885-d320-420c-c3dd-d8cc2c9c4d09@suse.com> (raw)
In-Reply-To: <20171123083019.GA20221@infradead.org>
On 23.11.2017 10:30, Christoph Hellwig wrote:
> On Thu, Nov 23, 2017 at 10:28:39AM +0200, Nikolay Borisov wrote:
>> What you are saying is that iomap currently always trims the returned
>> range from the underlying filesystem so doing trimming in the fs is
>> redundant and I can just pass XFS_BMAPI_ENTIRE indiscriminately ?
>
> I think so. But the theory needs proper valiation first, so please
> do a full test run with that change.
>
Right, so no new failures introduced by always passing XFS_BMAP_ENTIRE
so I will resend the patch.
prev parent reply other threads:[~2017-11-23 11:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-23 8:06 [PATCH] xfs: Don't trim extents for fiemap Nikolay Borisov
2017-11-23 8:15 ` Christoph Hellwig
2017-11-23 8:28 ` Nikolay Borisov
2017-11-23 8:30 ` Christoph Hellwig
2017-11-23 11:35 ` Nikolay Borisov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01f6e885-d320-420c-c3dd-d8cc2c9c4d09@suse.com \
--to=nborisov@suse.com \
--cc=darrick.wong@oracle.com \
--cc=hch@infradead.org \
--cc=linux-xfs@vger.kernel.org \
--cc=sandeen@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).