From: "Holger Hoffstätte" <holger@applied-asynchrony.com>
To: linux-xfs <linux-xfs@vger.kernel.org>
Subject: Sorting blocks in xfs_buf_delwri_submit_buffers() still necessary?
Date: Wed, 13 Oct 2021 19:13:10 +0200 [thread overview]
Message-ID: <05c69404-cc05-444b-e4b0-1e358deae272@applied-asynchrony.com> (raw)
Hi,
Based on what's going on in blk-mq & NVMe land I though I'd check if XFS still
sorts buffers before sending them down the pipe, and sure enough that still
happens in xfs_buf.c:xfs_buf_delwri_submit_buffers() (the comparson function
is directly above). Before I make a fool of myself and try to remove this,
do we still think this is necessary? If there's a scheduler it will do the
same thing, and SSD/NVMe might do the same in HW anyway or not care.
The only scenario I can think of where this might make a difference is
rotational RAID without scheduler attached. Not sure.
I'm looking forward to hear what a foolish idea this is.
cheers
Holger
next reply other threads:[~2021-10-13 17:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-13 17:13 Holger Hoffstätte [this message]
2021-10-13 20:57 ` Sorting blocks in xfs_buf_delwri_submit_buffers() still necessary? Dave Chinner
2021-10-14 7:33 ` Holger Hoffstätte
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=05c69404-cc05-444b-e4b0-1e358deae272@applied-asynchrony.com \
--to=holger@applied-asynchrony.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).