From: corinhoad@gmail.com
To: linux-xfs@vger.kernel.org
Subject: [bug report] xfsdump fails to build against xfsprogs 5.18.0
Date: Tue, 28 Jun 2022 23:32:48 +0100 [thread overview]
Message-ID: <089bacd9-6213-d73f-f188-d4a31d91f447@gmail.com> (raw)
Hello,
I package xfsdump for NixOS, and I have found that a recent upgrade from
xfsprogs 5.16.0 to 5.18.0 has caused a build failure for xfsprogs. See
[1] for an excerpt from the build logs. My novice investigation of the
issue and disccusion IRC indicates that the removal of DMAPI support is
behind this.
Best,
Corin Hoad
[1]
content.c: In function 'restore_complete_reg':
content.c:7727:29: error: storage size of 'fssetdm' isn't known
7727 | fsdmidata_t fssetdm;
| ^~~~~~~
content.c:7734:34: error: 'XFS_IOC_FSSETDM' undeclared (first use in
this function); did you mean 'XFS_IOC_FSSETXATTR'?
7734 | rval = ioctl(fd, XFS_IOC_FSSETDM, (void
*)&fssetdm);
| ^~~~~~~~~~~~~~~
| XFS_IOC_FSSETXATTR
content.c:7734:34: note: each undeclared identifier is reported only
once for each function it appears in
content.c:7727:29: warning: unused variable 'fssetdm' [-Wunused-variable]
7727 | fsdmidata_t fssetdm;
| ^~~~~~~
content.c: In function 'restore_symlink':
content.c:8061:29: error: storage size of 'fssetdm' isn't known
8061 | fsdmidata_t fssetdm;
| ^~~~~~~
content.c:8061:29: warning: unused variable 'fssetdm' [-Wunused-variable]
content.c: In function 'setextattr':
content.c:8867:9: warning: 'attr_set' is deprecated: Use setxattr or
lsetxattr instead [-Wdeprecated-declarations]
8867 | rval = attr_set(path,
| ^~~~
In file included from content.c:27:
/nix/store/7b84p7877fl9p8aqx392drggj0jkqd0j-attr-2.5.1-dev/include/attr/attributes.h:139:12:
note: declared here
139 | extern int attr_set (const char *__path, const char *__attrname,
| ^~~~~~~~
content.c: In function 'Media_mfile_next':
content.c:4797:33: warning: ignoring return value of 'system' declared
with attribute 'warn_unused_result' [-Wunused-result]
4797 | system(media_change_alert_program);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
content.c: In function 'restore_extent':
content.c:8625:49: warning: ignoring return value of 'ftruncate'
declared with attribute 'warn_unused_result' [-Wunused-result]
8625 | ftruncate(fd,
bstatp->bs_size);
|
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
make[2]: *** [../include/buildrules:47: content.o] Error 1
make[1]: *** [include/buildrules:23: restore] Error 2
make: *** [Makefile:53: default] Error 2
next reply other threads:[~2022-06-28 22:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-28 22:32 corinhoad [this message]
2022-06-28 22:59 ` [bug report] xfsdump fails to build against xfsprogs 5.18.0 Darrick J. Wong
2022-06-29 8:59 ` Corin Hoad
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=089bacd9-6213-d73f-f188-d4a31d91f447@gmail.com \
--to=corinhoad@gmail.com \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).