* [PATCH] xfs_io: copy_range can take up to 8 arguments
@ 2020-04-30 21:41 Eric Sandeen
2020-05-01 8:07 ` Christoph Hellwig
0 siblings, 1 reply; 2+ messages in thread
From: Eric Sandeen @ 2020-04-30 21:41 UTC (permalink / raw)
To: linux-xfs
If we use the "-f N" variant for the source file specification, we will
have up to 8 total arguments.
Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
diff --git a/io/copy_file_range.c b/io/copy_file_range.c
index 68525047..d154fa76 100644
--- a/io/copy_file_range.c
+++ b/io/copy_file_range.c
@@ -179,7 +179,7 @@ copy_range_init(void)
copy_range_cmd.name = "copy_range";
copy_range_cmd.cfunc = copy_range_f;
copy_range_cmd.argmin = 1;
- copy_range_cmd.argmax = 7;
+ copy_range_cmd.argmax = 8;
copy_range_cmd.flags = CMD_NOMAP_OK | CMD_FOREIGN_OK;
copy_range_cmd.args = _("[-s src_off] [-d dst_off] [-l len] src_file | -f N");
copy_range_cmd.oneline = _("Copy a range of data between two files");
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] xfs_io: copy_range can take up to 8 arguments
2020-04-30 21:41 [PATCH] xfs_io: copy_range can take up to 8 arguments Eric Sandeen
@ 2020-05-01 8:07 ` Christoph Hellwig
0 siblings, 0 replies; 2+ messages in thread
From: Christoph Hellwig @ 2020-05-01 8:07 UTC (permalink / raw)
To: Eric Sandeen; +Cc: linux-xfs
On Thu, Apr 30, 2020 at 04:41:55PM -0500, Eric Sandeen wrote:
> If we use the "-f N" variant for the source file specification, we will
> have up to 8 total arguments.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-05-01 8:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-04-30 21:41 [PATCH] xfs_io: copy_range can take up to 8 arguments Eric Sandeen
2020-05-01 8:07 ` Christoph Hellwig
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).