Re: [PATCH V3 4/6] nvmet: ignore discard return value

Chaitanya Kulkarni
2026-01-27T22:41:01Z

On 1/25/26 20:57, hch@lst.de wrote:
> On Sat, Jan 24, 2026 at 09:35:16PM +0000, Chaitanya Kulkarni wrote:
>> On 11/24/25 15:48, Chaitanya Kulkarni wrote:
>>> __blkdev_issue_discard() always returns 0, making the error checking
>>> in nvmet_bdev_discard_range() dead code.
>>>
>>> Kill the function nvmet_bdev_discard_range() and call
>>> __blkdev_issue_discard() directly from nvmet_bdev_execute_discard(),
>>> since no error handling is needed anymore for __blkdev_issue_discard()
>>> call.
>>>
>>> Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
>>> Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
>>> Reviewed-by: Christoph Hellwig <hch@lst.de>
>>> Signed-off-by: Chaitanya Kulkarni <ckulkarnilinux@gmail.com>
>>> ---
>> Gentle ping on this, can we apply this patch ?
> Are we down to three patches now? Maybe resend the whole series and
> get ACKs to merge everything through the block layer?
>
sounds good, will re-spin the remaining patches on linux-block/for-next.

-ck