From: Allison Henderson <allison.henderson@oracle.com>
To: Dave Chinner <david@fromorbit.com>,
"Darrick J. Wong" <djwong@kernel.org>
Cc: linux-xfs@vger.kernel.org
Subject: Re: [PATCH v22 14/16] xfs: Add delattr mount option
Date: Wed, 28 Jul 2021 02:05:09 -0700 [thread overview]
Message-ID: <09ec631f-4cd8-cd6e-ea2c-76dab5d4b26f@oracle.com> (raw)
In-Reply-To: <20210728021303.GA2757197@dread.disaster.area>
On 7/27/21 7:13 PM, Dave Chinner wrote:
> On Tue, Jul 27, 2021 at 05:47:57PM -0700, Darrick J. Wong wrote:
>> On Mon, Jul 26, 2021 at 11:20:51PM -0700, Allison Henderson wrote:
>>> This patch adds a mount option to enable delayed attributes. Eventually
>>> this can be removed when delayed attrs becomes permanent.
>>>
>>> Signed-off-by: Allison Henderson <allison.henderson@oracle.com>
>>> ---
>>> fs/xfs/libxfs/xfs_attr.h | 2 +-
>>> fs/xfs/xfs_mount.h | 1 +
>>> fs/xfs/xfs_super.c | 11 ++++++++++-
>>> fs/xfs/xfs_xattr.c | 2 ++
>>> 4 files changed, 14 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/fs/xfs/libxfs/xfs_attr.h b/fs/xfs/libxfs/xfs_attr.h
>>> index c0c92bd3..d4e7521 100644
>>> --- a/fs/xfs/libxfs/xfs_attr.h
>>> +++ b/fs/xfs/libxfs/xfs_attr.h
>>> @@ -30,7 +30,7 @@ struct xfs_attr_list_context;
>>>
>>> static inline bool xfs_hasdelattr(struct xfs_mount *mp)
>>> {
>>> - return false;
>>> + return mp->m_flags & XFS_MOUNT_DELATTR;
>>> }
>>>
>>> /*
>>> diff --git a/fs/xfs/xfs_mount.h b/fs/xfs/xfs_mount.h
>>> index 66a47f5..2945868 100644
>>> --- a/fs/xfs/xfs_mount.h
>>> +++ b/fs/xfs/xfs_mount.h
>>> @@ -257,6 +257,7 @@ typedef struct xfs_mount {
>>> #define XFS_MOUNT_NOATTR2 (1ULL << 25) /* disable use of attr2 format */
>>> #define XFS_MOUNT_DAX_ALWAYS (1ULL << 26)
>>> #define XFS_MOUNT_DAX_NEVER (1ULL << 27)
>>> +#define XFS_MOUNT_DELATTR (1ULL << 28) /* enable delayed attributes */
>>
>> So uh while we're renaming things away from "delattr", maybe this ...
>>
>> LOGGED ATTRIBUTE RE PLAY
>>
>> ... really should become the "larp" debug-only mount option.
>>
>> XFS_MOUNT_LARP
>>
>> Yeah. Do it!!!
>>
>>> /*
>>> * Max and min values for mount-option defined I/O
>>> diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c
>>> index 2c9e26a..39d6645 100644
>>> --- a/fs/xfs/xfs_super.c
>>> +++ b/fs/xfs/xfs_super.c
>>> @@ -94,7 +94,7 @@ enum {
>>> Opt_filestreams, Opt_quota, Opt_noquota, Opt_usrquota, Opt_grpquota,
>>> Opt_prjquota, Opt_uquota, Opt_gquota, Opt_pquota,
>>> Opt_uqnoenforce, Opt_gqnoenforce, Opt_pqnoenforce, Opt_qnoenforce,
>>> - Opt_discard, Opt_nodiscard, Opt_dax, Opt_dax_enum,
>>> + Opt_discard, Opt_nodiscard, Opt_dax, Opt_dax_enum, Opt_delattr
>>> };
>>>
>>> static const struct fs_parameter_spec xfs_fs_parameters[] = {
>>> @@ -139,6 +139,7 @@ static const struct fs_parameter_spec xfs_fs_parameters[] = {
>>> fsparam_flag("nodiscard", Opt_nodiscard),
>>> fsparam_flag("dax", Opt_dax),
>>> fsparam_enum("dax", Opt_dax_enum, dax_param_enums),
>>> + fsparam_flag("delattr", Opt_delattr),
>>
>> I think you need this line to be guarded by #ifdefs so that the mount
>> options parsing code will reject -o larp on non-debug kernels.
>
> As i mentioned on #xfs, this really should be like the "always_cow"
> debug option - access it via /sys/fs/xfs/debug/larping_with_larts -
> rather than being a mount option that users might accidentally
> discover and start using...
>
> Cheers,
>
> Dave.
Sure, if folks are ok with that, I'll take a look at always_cow, and see
if I can put together something similar for larp. Or larping_with_larts
if folks prefer :-) Thanks for the review!
Allison
>
next prev parent reply other threads:[~2021-07-28 9:05 UTC|newest]
Thread overview: 67+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-27 6:20 [PATCH v22 00/16] Delayed Attributes Allison Henderson
2021-07-27 6:20 ` [PATCH v22 01/16] xfs: allow setting and clearing of log incompat feature flags Allison Henderson
2021-07-27 12:24 ` Chandan Babu R
2021-07-28 9:01 ` Allison Henderson
2021-07-27 6:20 ` [PATCH v22 02/16] xfs: clear log incompat feature bits when the log is idle Allison Henderson
2021-07-27 12:46 ` Chandan Babu R
2021-07-28 9:02 ` Allison Henderson
2021-07-27 6:20 ` [PATCH v22 03/16] xfs: refactor xfs_iget calls from log intent recovery Allison Henderson
2021-07-28 11:54 ` Chandan Babu R
2021-07-30 9:17 ` Allison Henderson
2021-07-27 6:20 ` [PATCH v22 04/16] xfs: Return from xfs_attr_set_iter if there are no more rmtblks to process Allison Henderson
2021-07-27 23:30 ` Darrick J. Wong
2021-07-28 9:01 ` Allison Henderson
2021-07-28 12:18 ` Chandan Babu R
2021-07-30 9:17 ` Allison Henderson
2021-08-09 17:24 ` Darrick J. Wong
2021-07-27 6:20 ` [PATCH v22 05/16] xfs: Add state machine tracepoints Allison Henderson
2021-07-28 13:42 ` Chandan Babu R
2021-07-30 9:17 ` Allison Henderson
2021-07-27 6:20 ` [PATCH v22 06/16] xfs: Rename __xfs_attr_rmtval_remove Allison Henderson
2021-07-29 7:56 ` Chandan Babu R
2021-07-30 9:17 ` Allison Henderson
2021-07-27 6:20 ` [PATCH v22 07/16] xfs: Handle krealloc errors in xlog_recover_add_to_cont_trans Allison Henderson
2021-07-29 8:27 ` Chandan Babu R
2021-07-30 9:17 ` Allison Henderson
2021-07-27 6:20 ` [PATCH v22 08/16] xfs: Set up infrastructure for deferred attribute operations Allison Henderson
2021-07-28 0:56 ` Darrick J. Wong
2021-07-28 9:04 ` Allison Henderson
2021-07-30 4:46 ` Chandan Babu R
2021-07-30 9:17 ` Allison Henderson
2021-07-27 6:20 ` [PATCH v22 09/16] xfs: Implement attr logging and replay Allison Henderson
2021-07-27 9:38 ` Chandan Babu R
2021-07-28 9:01 ` Allison Henderson
2021-07-28 0:39 ` Darrick J. Wong
2021-07-28 9:05 ` Allison Henderson
2021-07-30 12:21 ` Chandan Babu R
2021-08-02 8:33 ` Allison Henderson
2021-07-27 6:20 ` [PATCH v22 10/16] RFC xfs: Skip flip flags for delayed attrs Allison Henderson
2021-07-28 19:18 ` Darrick J. Wong
2021-07-31 5:11 ` Allison Henderson
2021-08-02 7:47 ` Allison Henderson
2021-07-30 14:40 ` Chandan Babu R
2021-08-02 8:33 ` Allison Henderson
2021-07-27 6:20 ` [PATCH v22 11/16] xfs: Add xfs_attr_set_deferred and xfs_attr_remove_deferred Allison Henderson
2021-07-28 19:24 ` Darrick J. Wong
2021-08-02 8:18 ` Allison Henderson
2021-07-30 14:58 ` Chandan Babu R
2021-08-02 8:33 ` Allison Henderson
2021-07-27 6:20 ` [PATCH v22 12/16] xfs: Remove unused xfs_attr_*_args Allison Henderson
2021-07-28 19:31 ` Darrick J. Wong
2021-08-02 8:11 ` Allison Henderson
2021-08-02 3:26 ` Chandan Babu R
2021-08-02 8:33 ` Allison Henderson
2021-07-27 6:20 ` [PATCH v22 13/16] xfs: Add delayed attributes error tag Allison Henderson
2021-08-02 3:27 ` Chandan Babu R
2021-08-02 8:33 ` Allison Henderson
2021-07-27 6:20 ` [PATCH v22 14/16] xfs: Add delattr mount option Allison Henderson
2021-07-28 0:47 ` Darrick J. Wong
2021-07-28 2:13 ` Dave Chinner
2021-07-28 9:05 ` Allison Henderson [this message]
2021-07-28 9:02 ` Allison Henderson
2021-07-27 6:20 ` [PATCH v22 15/16] xfs: Merge xfs_delattr_context into xfs_attr_item Allison Henderson
2021-08-02 3:27 ` Chandan Babu R
2021-08-02 8:33 ` Allison Henderson
2021-07-27 6:20 ` [PATCH v22 16/16] xfs: Add helper function xfs_attr_leaf_addname Allison Henderson
2021-07-28 19:52 ` Darrick J. Wong
2021-08-02 8:18 ` Allison Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=09ec631f-4cd8-cd6e-ea2c-76dab5d4b26f@oracle.com \
--to=allison.henderson@oracle.com \
--cc=david@fromorbit.com \
--cc=djwong@kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox