public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Nathan Scott <nscott@aconex.com>
To: xfs@oss.sgi.com, agruen@suse.de
Subject: Fwd: Bug#531950: attr: FTBFS on GNU/kFreeBSD
Date: Tue, 9 Jun 2009 10:03:28 +1000 (EST)	[thread overview]
Message-ID: <1001284815.6030901244505808497.JavaMail.root@mail-au.aconex.com> (raw)
In-Reply-To: <Pine.LNX.4.62.0906051023170.19804@sci.felk.cvut.cz>

Could someone verify and merge this patch?  It looks OK to
me.

thanks!

----- Forwarded Message -----
From: "Petr Salinger" <Petr.Salinger@seznam.cz>
To: submit@bugs.debian.org
Sent: Friday, June 5, 2009 6:45:33 PM GMT +10:00 Canberra / Melbourne / Sydney
Subject: Bug#531950: attr: FTBFS on GNU/kFreeBSD

Package: attr
Severity: important
Version: 1:2.4.43-2
Tags: patch
User: glibc-bsd-devel@lists.alioth.debian.org
Usertags: kfreebsd

Hi,

the current version fails to build on GNU/kFreeBSD.
It is kind of reopen of #414232.
Please use the patch bellow instead of the patch in #414232.

It might look surprisingly, but it is correct for all architectures.

The Linux uses ENODATA and does not define ENOATTR,
the GNU/kFreeBSD uses ENOATTR and does not define ENODATA
in errno.h (similarly as original SGI code).
Therefore the code in attr mainly uses ENOATTR,
see also include/xattr.h.

It would also be nice if you can ask upstream
to include this change.

Thanks in advance


Petr

only in patch2:
unchanged:
--- attr-2.4.43.orig/getfattr/getfattr.c
+++ attr-2.4.43/getfattr/getfattr.c
@@ -93,7 +93,7 @@

  const char *strerror_ea(int err)
  {
-       if (err == ENODATA)
+       if (err == ENOATTR)
                 return _("No such attribute");
         return strerror(err);
  }
only in patch2:
unchanged:
--- attr-2.4.43.orig/setfattr/setfattr.c
+++ attr-2.4.43/setfattr/setfattr.c
@@ -66,7 +66,7 @@

  const char *strerror_ea(int err)
  {
-       if (err == ENODATA)
+       if (err == ENOATTR)
                 return _("No such attribute");
         return strerror(err);
  }




-- 
Nathan

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

       reply	other threads:[~2009-06-09  0:03 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <Pine.LNX.4.62.0906051023170.19804@sci.felk.cvut.cz>
2009-06-09  0:03 ` Nathan Scott [this message]
2009-06-09  8:09   ` Fwd: Bug#531950: attr: FTBFS on GNU/kFreeBSD Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1001284815.6030901244505808497.JavaMail.root@mail-au.aconex.com \
    --to=nscott@aconex.com \
    --cc=agruen@suse.de \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox