From: David Howells <dhowells@redhat.com>
To: Christoph Hellwig <hch@lst.de>
Cc: dhowells@redhat.com, mbobrowski@mbobrowski.org,
darrick.wong@oracle.com, jack@suse.cz,
linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: Is ext4_dio_read_iter() broken? - and xfs_file_dio_aio_read()
Date: Thu, 12 Mar 2020 10:49:40 +0000 [thread overview]
Message-ID: <1023937.1584010180@warthog.procyon.org.uk> (raw)
In-Reply-To: <20200312104239.GA13235@lst.de>
Christoph Hellwig <hch@lst.de> wrote:
> > > at the end of the function - but surely iocb should be expected to have
> > > been freed when iocb->ki_complete() was called?
>
> The iocb is refcounted and only completed when the refcount hits zero,
> and an extra reference is held until the submission has completed.
> Take a look at iocb_put().
Ah... This is in struct aio_kiocb and not struct kiocb - that's why I missed
it. Thanks.
David
next prev parent reply other threads:[~2020-03-12 10:49 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <969260.1584004779@warthog.procyon.org.uk>
2020-03-12 10:07 ` Is ext4_dio_read_iter() broken? - and xfs_file_dio_aio_read() David Howells
2020-03-12 10:26 ` btrfs may be broken too - Re: Is ext4_dio_read_iter() broken? David Howells
2020-03-12 10:42 ` Is ext4_dio_read_iter() broken? - and xfs_file_dio_aio_read() Christoph Hellwig
2020-03-12 10:49 ` David Howells [this message]
2020-03-12 10:53 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1023937.1584010180@warthog.procyon.org.uk \
--to=dhowells@redhat.com \
--cc=darrick.wong@oracle.com \
--cc=hch@lst.de \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
--cc=mbobrowski@mbobrowski.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox