Re: [PATCH] mkfs.xfs: always use underlying fs sector size when mkfs'ing a file

Eric Sandeen
2015-06-19T15:17:13Z

On 6/19/15 10:09 AM, Christoph Hellwig wrote:
> On Thu, Jun 18, 2015 at 07:03:39AM -0400, Jan Tulak wrote:
>> This changes get_topology only for ENABLE_BLKID branch of #ifdef. Is that intentional, i.e. we don't expect anyone not using ENABLE_BLKID? Because otherwise, if mkfs is compiled without ENABLE_BLKID, then all we get is:
>
> I'm in favor of killing the !ENABLE_BLKID entirely. The proper
> support in blkid has been around long enough to require it.
>

though we also claim to nominally support building on osx, irix, etc, which doesn't have that library, right?

-Eric