Re: [PATCH v2] xfsprogs: blkid is now mandatory

[Jan Tulak <jtulak@redhat.com>]

----- Original Message -----
> From: "Christoph Hellwig" <hch@infradead.org>
> 
> Can you wrap your commit description lines after ~ 75 characters,
> please?
>
Sure. I changed it to ~ 68 by Dave's suggestion.

> 
> > +AC_HAVE_BLKID_TOPO(yes)
> 
> I don't think we'll need an unused argument for AC_HAVE_BLKID_TOPO.

Fixed.

> 
> > -Mac OS X Instructions
> > -=====================
> 
> Why do you remove this section?
> 

I shouldn't put it into this patch but a standalone one: I tried to build the current version of XFS on OS X (10.10 Yosemite), but so far without a success. (I got to some errors in #defines where I thought I have better things to do.) Neither Macports, nor Homebrew [*] seems to ships XFS... Essentially, even if our docs contain a howto for OS X, it is not working and it looks like no one is using it. So I found this section ready for discarding. :-)

Regarding OS X and blkid... Macports contains util-linux with libblkid, so the new dependency shouldn't be breaking the possibility to port it, if anyone wants to try it...

[*] Macports and Hombrew - two biggest (AFAIK the only ones who are widely used) software repositories for OS X in Linux/BSD style. Macports are basically a port of BSD's Port.

> >  
> >  default: depend $(LTCOMMAND)
> >  
> > -ifneq ($(ENABLE_BLKID),yes)
> > -default: $(FSTYP)
> > -endif
> > -
> >  include $(BUILDRULES)
> >  
> > -$(FSTYP):
> > -	@echo "    [CC]     $@"
> > -	$(Q)$(LTLINK) $@.c -o $@ $(CFLAGS) $(LDFLAGS) $(LIBDISK) $(PLDLIBS)
> > -
> 
> 
> Please remove fstyp.c  and the definition of FSTYP in the Makefile as well.
> 

I assume fstyp.h should go too...

Jan

-- 
Jan Tulak
jtulak@redhat.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs