Re: [PATCH v2] xfsprogs: blkid is now mandatory

Dave Chinner
2015-07-03T23:45:25Z

On Fri, Jul 03, 2015 at 08:19:04AM -0700, Christoph Hellwig wrote:
> Thanks Jan!
>
> On Thu, Jul 02, 2015 at 12:43:16PM +0200, Jan Tulak wrote:
> > Because blkid is here for a long time, I hereby propose a patch for removing support
> > for NOT having blkid. The current support through set of #ifdef is prone to errors like
> > making a patch just in one of the branches, and according to a recent talk between
> > Christoph and Eric, it is not necessary to keep it supported.
> >
> > Remove code for checking ENABLE_BLKID, and the code when ENABLE_BLKID is not defined.
> > The only use of libdisk was in the removed code, so remove libdisk too.
> > It makes blkid required for compilation.
>
> Can you wrap your commit description lines after ~ 75 characters,
> please?

ObBikeShed: I find 68 characters for commit messages is more
friendly, especially with the way git show pads the commit messages
and people cut/paste it into email...

Cheers,

Dave.
--
Dave Chinner
david@fromorbit.com