Re: [PATCH v3] xfsprogs: blkid is now mandatory

Eric Sandeen
2015-08-03T17:20:13Z

On 8/3/15 3:40 AM, Jan Tulak wrote:
>
>
> ----- Original Message -----
>> From: "Christoph Hellwig" <hch@infradead.org>
>>
>> On Tue, Jul 21, 2015 at 08:39:36AM -0400, Jan Tulak wrote:
>>> I just found that while it is possible to get blkid on OS X, it is
>>> in 1.0.0 version which doesn't have blkid_probe_get function.
>>> I'm examining whether it is possible to get an updated version there,
>>> but right now, this patch breaks OS X support. Unfortunately I didn't
>>> noticed of this before, as the OS X port was terribly out of date.
>>>
>>> So this patch shouldn't be included until I find how to get around.
>>
>> I don't think this is a lbocker given that OSX support doesn't
>> even work.
>>
>> To the contrary I'd really prefer to go in ASAP to avoid anyone
>> relying on it longer than nessecary.
>
> I tried to get newer blkid on OSX, but so far without a big success
> (well, it looks like a kind of a small dependency hell that would
> have to be ported, with bigger or smaller effort...). With regards
> on the priorities, I think if we can make the OS X support in
> "manual patching required" way, then?
>
> So lets include this patch, and just note it OS X doc "you have to revert
> commit XXX and re-apply any changes to the relevant code"?

IIRC block device signature detection isn't really required, it's just
a nice-to-have; perhaps if blkid isn't present, that functionality can
simply be disabled?

-Eric