Re: [PATCH v3] xfsprogs: blkid is now mandatory

Jan Tulak
2015-07-21T12:40:04Z

----- Original Message -----
> From: "Jan Tulak" <jtulak@redhat.com>
> Subject: [PATCH v3] xfsprogs: blkid is now mandatory
>
> Because blkid is here for a long time, I hereby propose a patch for
> removing support for NOT having blkid. The current support through
> set of #ifdef is prone to errors like
> making a patch just in one of the branches, and according to a
> recent talk between Christoph and Eric, it is not necessary to keep
> it supported.
>
> Remove code for checking ENABLE_BLKID, and the code when
> ENABLE_BLKID is not defined. The only use of libdisk was in the
> removed code, so remove libdisk too. It makes blkid required for
> compilation.
>

I just found that while it is possible to get blkid on OS X, it is
in 1.0.0 version which doesn't have blkid_probe_get function.
I'm examining whether it is possible to get an updated version there,
but right now, this patch breaks OS X support. Unfortunately I didn't
noticed of this before, as the OS X port was terribly out of date.

So this patch shouldn't be included until I find how to get around.

Cheers,
Jan

--
Jan Tulak
jtulak@redhat.com