Re: [PATCH] mkfs: add discard support

Nathan Scott
2009-10-06T19:23:15Z

----- "Christoph Hellwig" <hch@infradead.org> wrote:

> Index: xfsprogs-dev/mkfs/xfs_mkfs.c
> ===================================================================
> --- xfsprogs-dev.orig/mkfs/xfs_mkfs.c 2009-10-06 18:02:34.000000000
> +0000
> +++ xfsprogs-dev/mkfs/xfs_mkfs.c 2009-10-06 18:03:55.000000000 +0000
> @@ -605,6 +605,29 @@ done:
> free(buf);
> }
>
> +#ifdef __linux__
> +
> +#ifndef BLKDISCARD
> +#define BLKDISCARD _IO(0x12,119)
> +#endif

It might be a bit cleaner to add this in with the existing platform-
specific code in libxfs/linux.c (or perhaps include/platform_defs.h)
with wrappers for the other platforms, rather than putting it directly
in mkfs like this? repair may want to use this someday too, I guess.

cheers.

--
Nathan