From: Nathan Scott <nscott@aconex.com>
To: David Chinner <dgc@sgi.com>
Cc: xfs@oss.sgi.com
Subject: Re: Review: clean up inode i_flags handling
Date: Wed, 04 Oct 2006 09:58:50 +1000 [thread overview]
Message-ID: <1159919930.32536.14.camel@edge> (raw)
In-Reply-To: <1159914373.32536.9.camel@edge>
On Wed, 2006-10-04 at 08:26 +1000, Nathan Scott wrote:
> On Tue, 2006-10-03 at 15:13 +1000, David Chinner wrote:
> >
>
> This part seems like overkill, I'd just do that inline like the clear
> variant, since its just one instruction ...
>
..but I guess you did it for consistency, as that one instruction is
otherwise going to have to be open coded in a few places ... *shrug*
looks good to me either way.
cheers.
--
Nathan
prev parent reply other threads:[~2006-10-03 23:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-03 5:13 Review: clean up inode i_flags handling David Chinner
2006-10-03 22:26 ` Nathan Scott
2006-10-03 23:58 ` Nathan Scott [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1159919930.32536.14.camel@edge \
--to=nscott@aconex.com \
--cc=dgc@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox