From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: with ECARTIS (v1.0.0; list xfs); Sun, 19 Nov 2006 15:40:20 -0800 (PST) Received: from page.mel.office.aconex.com (mail.aconex.com [150.101.159.26]) by oss.sgi.com (8.12.10/8.12.10/SuSE Linux 0.7) with ESMTP id kAJNeCaG026919 for ; Sun, 19 Nov 2006 15:40:14 -0800 Subject: Re: [PATCH] (and bad attr2 bug) - pack xfs_sb_t for 64-bit arches From: Nathan Scott Reply-To: nscott@aconex.com In-Reply-To: <48064.10.0.0.2.1163776850.squirrel@sandeen.net> References: <455CB54F.8080901@sandeen.net> <20061117023946.GN11034@melbourne.sgi.com> <20061117055521.GS11034@melbourne.sgi.com> <52841.10.0.0.2.1163745285.squirrel@sandeen.net> <1163746343.4695.152.camel@edge> <48064.10.0.0.2.1163776850.squirrel@sandeen.net> Content-Type: text/plain Date: Mon, 20 Nov 2006 10:11:46 +1100 Message-Id: <1163977907.4695.157.camel@edge> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: xfs-bounce@oss.sgi.com Errors-to: xfs-bounce@oss.sgi.com List-Id: xfs To: sandeen@sandeen.net Cc: David Chinner , Timothy Shimmin , xfs@oss.sgi.com On Fri, 2006-11-17 at 09:20 -0600, sandeen@sandeen.net wrote: > > On Fri, 2006-11-17 at 00:34 -0600, sandeen@sandeen.net wrote: > >> and really, now that this is out in the wild, maybe sb_features3 > >> instead of padding is appropriate, and check both for the attr2 > >> bit...? :( > > > > Thats not going to work, theres three or four other feature2 bits > > preceding attr2 as well. > > > > The "take a 32 bit systems fs to a 64 bit system" is relatively > > uncommon, so I suppose its just something we live with (as we did > > with the log recovery issues in that situation for several years). > > So you think this should not be fixed, then? Because if it -is- fixed I didn't say that. It should be fixed. Noone will notice though, as its not actually biting anyone... (the attr2 problem will not be related to this, its gonna be something else). > then it's not an fs transfer problem; suddenly 64-bit attr2 filesystems > will think they have attr1 if proper padding is added. Now to really fry your noodle, attr2 is actually ondisk compatible with attr1. :) (the SB bit was taken to prevent a repair buglet from accidentally trashing all inodes using a non-fixed forkoff). cheers. -- Nathan