* Re: [xfs-masters] Re: 2.6.19-rc6 : Spontaneous reboots, stack overflows - seems to implicate xfs, scsi, networking, SMP
[not found] ` <1164269545.31358.771.camel@laptopd505.fenrus.org>
@ 2006-11-23 22:08 ` Nathan Scott
2006-11-26 14:31 ` Eric Sandeen
1 sibling, 0 replies; 2+ messages in thread
From: Nathan Scott @ 2006-11-23 22:08 UTC (permalink / raw)
To: xfs-masters
Cc: Al Viro, David Miller, dgc, jesper.juhl, chatz, linux-kernel, xfs,
netdev, linux-scsi
On Thu, 2006-11-23 at 09:12 +0100, Arjan van de Ven wrote:
> On Thu, 2006-11-23 at 04:35 +0000, Al Viro wrote:
> > > I would even say 10 function calls deep to allocate file blocks
> > > is overkill, but 22 it just astronomically bad.
> >
> > Especially since a large part is due to cxfs...
> > -
>
> it's a bit sad to see XFS this crippled in linux due to an external,
> proprietary module ;(
Heh, never let reality get in the way of a good conspiracy theory.
The stack depth in XFS is more a factor of the complexity of the
XFS space allocation algorithms, and is unrelated to CXFS.
I'm sure if people would point to specific stack issues they would
(continue to) get addressed. Its just so much easier to speculate
randomly though...
cheers.
--
Nathan
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: 2.6.19-rc6 : Spontaneous reboots, stack overflows - seems to implicate xfs, scsi, networking, SMP
[not found] ` <1164269545.31358.771.camel@laptopd505.fenrus.org>
2006-11-23 22:08 ` [xfs-masters] Re: 2.6.19-rc6 : Spontaneous reboots, stack overflows - seems to implicate xfs, scsi, networking, SMP Nathan Scott
@ 2006-11-26 14:31 ` Eric Sandeen
1 sibling, 0 replies; 2+ messages in thread
From: Eric Sandeen @ 2006-11-26 14:31 UTC (permalink / raw)
To: Arjan van de Ven
Cc: Al Viro, David Miller, dgc, jesper.juhl, chatz, linux-kernel, xfs,
xfs-masters, netdev, linux-scsi
Arjan van de Ven wrote:
> On Thu, 2006-11-23 at 04:35 +0000, Al Viro wrote:
>>> I would even say 10 function calls deep to allocate file blocks
>>> is overkill, but 22 it just astronomically bad.
>> Especially since a large part is due to cxfs...
>> -
>
> it's a bit sad to see XFS this crippled in linux due to an external,
> proprietary module ;(
>
I understand that cxfs is a bit of a whipping-boy, but the stacks in
question in this thread really don't have much if anything to do with
the filesystem layering in xfs. They are deep callchains & large
functions in core xfs code, it seems.
-Eric
^ permalink raw reply [flat|nested] 2+ messages in thread